[Lustre-devel] [wc-discuss] Lustre code style Git commit hooks and

[James Simmons]

> > On 2011-11-03, at 4:28 PM, Prakash Surya <surya1 at llnl.gov> wrote:
> > > I like the idea of cleaning up the commit messages in Lustre, although I
> > > feel enforcing these rules is better suited at the server level.
> > 
> > There are already limited checks at the server level, and they may be tightened in the near future.
> 
> And the most the server (which is Gerrit that we are talking about her)
> can do is to negatively review the patch as it does currently.  There is
> no mechanism to outright refuse to allow a push based on the content of
> the patch, so client-side is still the best place to apply these checks
> in an effort to prevent the patch from even being submitted if not
> correct.

Speaking of I just attempted to push a patch and noticed that no Change-Id 
is being generated when I commit a new patch. This is with the default 
hooks that I copied form build directory.