[Lustre-devel] [wc-discuss] Lustre code style Git commit hooks

[Andreas Dilger]

On 2011-11-09, at 12:23 PM, James Simmons wrote:
>> An earlier version of the commit-msg hook used "git hash-object -t commit" and it caused an empty Change-Id string for older versions of Git. The "-t commit" option was removed from the latest version and solved the problem for the people that used it.
> 
> Yes your right. I updated the hooks and it works now. I also had to learn 
> you need a subsystem: field for commits now. Info about the subsystem 
> field is not the wiki.

Hmm, which wiki page are you referring to?  The "Using Gerrit" page has had
the "component:" tag since june, long before I sent out the email,
and it was in the original email as well:

> The commit-msg hook verifies the format of the commit message itself,
> so that it contains a Jira ticket number, a "subsystem:" field, a
> commit body, and a Signed-off-by: line.  If no Gerrit "Change-Id:"
> line is present it will automatically add this as well.  The new
> "subsystem:" field is similar to those used for kernel commit messages
> all have, so that it is easier to decide what part of the code a patch
> affects.

If it is missing on some other wiki page, I'd like to correct it.

Cheers, Andreas
--
Andreas Dilger 
Principal Engineer
Whamcloud, Inc.