[Lustre-devel] [wc-discuss] Important changes to libcfs primitives usage.

Alexey Lyahkov alexey_lyashkov at xyratex.com
Fri Dec 14 00:19:03 PST 2012


Please don't kill a portability code.
We have spend many times in past to introduce it's but now you want to kill that work and make portable to systems other then Linux too hard.
That is wrong way as supporting a compatibility code have no cost.

On Dec 5, 2012, at 17:54, Oleg Drokin wrote:

> Hello!
> 
>   I just landed first patch of the series to reduce usage of our libcfs_ wrappers for kernel primitives like libcfs_spin_lock/unlock...
>   You can see actual change here: http://review.whamcloud.com/#change,2829
> 
>   It's highly likely that plenty of patches will be affected. To make our job easier, there is a
>   build/libcfs_cleanup.sed script included, you can run it on all your .c and .h files to make necessary replacements:
>   sed -i -f build/libcfs_cleanup.sed3  `find . -name "*.h" -or -name "*.c"`
> 
>   Please be also advised that there are more changes like this are coming (timeline is not very clear ATM, we might be able to wait with the rest until
>   after feature freeze) and the sed script will be updated accordingly.
> 
> Bye,
>    Oleg
> --
> Oleg Drokin
> Senior Software Engineer
> Whamcloud, Inc.
> 

----------------------------------------------
Alexey Lyahkov
alexey_lyashkov at xyratex.com





More information about the lustre-devel mailing list