[Lustre-devel] OFLAGS change.

Alexey Lyahkov alexey_lyashkov at xyratex.com
Thu Dec 20 03:06:35 PST 2012

On Dec 20, 2012, at 06:32, Peng, Tao wrote:
>>> reason to use autoconf macroses - we can't trust a RHEL/SuSe kernel
>>> version/
> Well, there are situations that autoconf cannot handle properly, such as the open_flag change by upstream commit (8a5e929dd2e05ab4d3d89f58c5e8fca596af8f3a). The change is inline so we cannot tell it without grepping the source file (fs/namei.c) which is likely unavailable when users build Lustre client from source. We currently solved it by putting a LINUX_VERSION_CODE check there but as you see it is not trustworthy when vendors backport patches.
> And IMO, the right way to solve such problems is to put Lustre in upstream/stable kernels and let vendors ship it so that they match in the first place.

static inline int ll_namei_to_lookup_intent_flag(int flag)
<------>flag = (flag & ~O_ACCMODE) | OPEN_FMODE(flag);
<------>return flag;

if i correctly understand - that change have a dependence to the OPEN_FMODE macro - not a kernel version.
so for any kernels have a OPEN_FMODE - we need to use that function, otherwise use flags directly.

Alexey Lyahkov
alexey_lyashkov at xyratex.com

More information about the lustre-devel mailing list