[Lustre-devel] For ptlrpc and related modules cleanup

Xuezhao.Liu at emc.com Xuezhao.Liu at emc.com
Wed Feb 29 00:29:15 PST 2012

Hi Johann,

As we only need to compile lquota module and defines HAVE_QUOTA_SUPPORT as 1 when Lustre is configured without “--disable-server” option and without “--enable-quota=no” option.
So indeed all HAVE_QUOTA_SUPPORT macros inside all source files of lustre/quota can be removed to make the code looks clean. (indeed we only compile lustre/quota in the case HAVE_QUOTA_SUPPORT is defined as 1).

And there are some function declarations inside quota_internal.h -- client_quota_adjust_qunit, lov_quota_adjust_qunit etc., neither they have function body nor have callers. So these declarations can be removed. (or has other reasons to remain them?)

This email can be ignored if I am correct and please correct me if I am wrong. Thanks!

Best Regards,
-----Original Message-----
From: lustre-devel-bounces at lists.lustre.org [mailto:lustre-devel-bounces at lists.lustre.org] On Behalf Of Johann Lombardi
Sent: 2012年2月22日 4:51
To: Andreas Dilger
Cc: Tang, Haiying; lustre-devel at lists.opensfs.org; Bryon Neitzel; Liu, Xuezhao; faibish, sorin; Lustre Devel
Subject: Re: [Lustre-devel] For ptlrpc and related modules cleanup

On Tue, Feb 21, 2012 at 01:02:25PM -0700, Andreas Dilger wrote:
> I think this list of tasks looks reasonable.  Johann should comment on the lquota module changes, since there is a considerable amount of other work being done on that code, and the changes being made should be coordinated to avoid conflict.

As of 2.2, the lquota module isn't needed on the client side any more (see http://review.whamcloud.com/#change,1613). I would thus be delighted if this module isn't built with --disable-server, as suggested in the document.

Johann Lombardi
Whamcloud, Inc.
Lustre-devel mailing list
Lustre-devel at lists.lustre.org

More information about the lustre-devel mailing list