[lustre-devel] [PATCH] [PATCH] staging/lustre: Remove unused MDS_CLOSE_CLEANUP define

[Dilger, Andreas]

The flag is no longer used in the code so there is no value to keep it around. It was only ever used for SOM, which was deleted and never supported. 

Cheers, Andreas

> On Jul 7, 2015, at 13:57, Christopher J. Morrone <morrone2 at llnl.gov> wrote:
> 
> Unless there is code in this client that explicitly prevents it from connecting with a pre-2.4.0 server, perhaps this flag should not be removed.
> 
> Chris
> 
>> On 07/07/2015 08:32 AM, Ben Evans wrote:
>> Previously, MDS_CLOSE_CLEANUP was used to detect file closing,
>> due to eviction. This flag is no longer used.
>> 
>> Signed-off-by: Aurelien Degremont <aurelien.degremont at cea.fr>
>> Intel-bug-ID: http://jira.hpdd.intel.com/browse/LU-3677
>> Reviewed-on: http://review.whamcloud.com/7195
>> Reviewed-by: Andreas Dilger <andreas.dilger at intel.com>
>> Reviewed-by: Jinshan Xiong <jinshan.xiong at intel.com>
>> Reviewed-by: John L. Hammond <john.hammond at intel.com>
>> Reviewed-by: Fan Yong <fan.yong at intel.com>
>> Reviewed-by: Oleg Drokin <oleg.drokin at intel.com>
>> Signed-off-by: Ben Evans <bevans at cray.com>
>> ---
>>  .../lustre/lustre/include/lustre/lustre_idl.h      |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>> 
>> diff --git a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h b/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
>> index 4d72d6e..bea70cb 100644
>> --- a/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
>> +++ b/drivers/staging/lustre/lustre/include/lustre/lustre_idl.h
>> @@ -2390,7 +2390,7 @@ enum mds_op_bias {
>>      MDS_PERM_BYPASS        = 1 << 3,
>>      MDS_SOM            = 1 << 4,
>>      MDS_QUOTA_IGNORE    = 1 << 5,
>> -    MDS_CLOSE_CLEANUP    = 1 << 6,
>> +    /* MDS_CLOSE_CLEANUP = 1 << 6, obsolete since 2.4.0 */
>>      MDS_KEEP_ORPHAN        = 1 << 7,
>>      MDS_RECOV_OPEN        = 1 << 8,
>>      MDS_DATA_MODIFIED    = 1 << 9,
> 
> _______________________________________________
> lustre-devel mailing list
> lustre-devel at lists.lustre.org
> http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org