[lustre-devel] Fwd: [HPDD-discuss] [PATCH 01/12] staging: lustre: fid: Use !x to check for kzalloc failure

Simmons, James A. simmonsja at ornl.gov
Mon Jun 22 10:18:53 PDT 2015

>Question for lustre-devel...  Isn't this the opposite of the style that we're currently trying to use in Gerrit submissions?  Is my memory faulty?

You are correct. Is this change really necessary? I will respone shortly.

-------- Original Message --------

[HPDD-discuss] [PATCH 01/12] staging: lustre: fid: Use !x to check for kzalloc failure


Sat, 20 Jun 2015 18:58:59 +0200


Julia Lawall <Julia.Lawall at lip6.fr><mailto:Julia.Lawall at lip6.fr>


Oleg Drokin <oleg.drokin at intel.com><mailto:oleg.drokin at intel.com>


<devel at driverdev.osuosl.org><mailto:devel at driverdev.osuosl.org>, Greg Kroah-Hartman <gregkh at linuxfoundation.org><mailto:gregkh at linuxfoundation.org>, <kernel-janitors at vger.kernel.org><mailto:kernel-janitors at vger.kernel.org>, <linux-kernel at vger.kernel.org><mailto:linux-kernel at vger.kernel.org>, <HPDD-discuss at lists.01.org><mailto:HPDD-discuss at lists.01.org>

!x is more normal for kzalloc failure in the kernel.

The semantic patch that makes this change is as follows:


// <smpl>


expression x;

statement S1, S2;


x = kzalloc(...);

if (

- x == NULL

+ !x

 ) S1 else S2

// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall at lip6.fr><mailto:Julia.Lawall at lip6.fr>


 drivers/staging/lustre/lustre/fid/fid_request.c |    4 ++--

 1 file changed, 2 insertions(+), 2 deletions(-)

diff -u -p a/drivers/staging/lustre/lustre/fid/fid_request.c b/drivers/staging/lustre/lustre/fid/fid_request.c

--- a/drivers/staging/lustre/lustre/fid/fid_request.c

+++ b/drivers/staging/lustre/lustre/fid/fid_request.c

@@ -498,11 +498,11 @@ int client_fid_init(struct obd_device *o

        int rc;

        cli->cl_seq = kzalloc(sizeof(*cli->cl_seq), GFP_NOFS);

-       if (cli->cl_seq == NULL)

+       if (!cli->cl_seq)

               return -ENOMEM;

        prefix = kzalloc(MAX_OBD_NAME + 5, GFP_NOFS);

-       if (prefix == NULL) {

+       if (!prefix) {

               rc = -ENOMEM;

               goto out_free_seq;



HPDD-discuss mailing list

HPDD-discuss at lists.01.org<mailto:HPDD-discuss at lists.01.org>


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lustre.org/pipermail/lustre-devel-lustre.org/attachments/20150622/cc615a1b/attachment.htm>

More information about the lustre-devel mailing list