[lustre-devel] [PATCH v4 00/13] staging: lustre: lnet: code cleanups
shuey at purdue.edu
Fri May 22 15:48:26 PDT 2015
I can definitely clean up the issues you (and others) have raised, and will
work on breaking up the larger changes into smaller, topic-based sets as
well. I could use some instruction on how to proceed, though...
I presume in this case I should've flagged this series as an RFC, and
started to advertise a merge-able patch when most of the feedback was
resolved (and not added additional cleanups to the series already under
review). What do I do with the cleanups in the present case - re-label
them as an RFC, repost all patches for comment (including the things added
in what I've labelled v4), and send a final patch series when all comments
are resolved? Or break them up into the previous PATCH v3 set, which had
no comments, plus a second series tagged RFC (at least until I've got a
sense of appropriate cleanup and granularity)?
Also, in the future, at what point is it safe to assume a set of patches
will be merged? And how do I indicate dependencies between series of
patches? This last is fairly important to me, given the overlaps with some
of James' work; we're beginning to coordinate via email, but I'd like to
find out the general expectation here (and hopefully avoid this sort of
faux pas going forward).
Many thanks for your continued feedback and advice, Dan.
On Fri, May 22, 2015 at 5:21 AM, Dan Carpenter <dan.carpenter at oracle.com>
> On Thu, May 21, 2015 at 03:50:23PM -0400, Mike Shuey wrote:
> > This patch series cleans up code in staging/lustre/lnet - mostly spacing
> > and dead function cleanup. Should apply against linux-next 20150518.
> Why are you sending a v4 of this? We don't actually enjoy reviewing the
> same patchset over and over...
> Update: I have investigated and it is because you add a few new patches
> to this set which were not in the original. Just assume that the
> original patchset will be merge and send the additional patches as a new
> Also since no one replied to the v3 patchset and Greg has a 5000 patches
> in between v3 and v4 he will not seen v4 until days after he has applied
> v3 so it causes confusion.
> Also you sent a v5 of this patchset but without a v5 label...
> dan carpenter
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the lustre-devel