[lustre-devel] [PATCH 1/3] staging: lustre: checkpatch cleanups for nidstring.c

Dan Carpenter dan.carpenter at oracle.com
Mon Nov 2 06:48:38 PST 2015


Yeah.  That is often the fastest way to fix all the checkpatch warnings.

Checkpatch warnings are pretty mechanical.  Just send like 100 patches
at a time until everything is fixed.  Don't overthink.  Say your patch
breaks the alignment then you have to fix that, but otherwise only fix
one thing at a time.  Sometimes people will ask you to fix something
else on the same line, but just say "I didn't introduce that, but yes I
am planning to fix that in a later patchset since I am following the
one thing per patch rule."

Don't feel shame about sending many small patches.  We pretty much merge
everything.

regards,
dan carpenter


More information about the lustre-devel mailing list