[lustre-devel] [RESEND PATCH v2 2/5] staging: lustre: hash.c: Replace IS_PO2 by is_power_of_2
Sudip Mukherjee
sudipm.mukherjee at gmail.com
Tue Oct 27 23:41:59 PDT 2015
On Tue, Oct 27, 2015 at 07:43:34PM +0200, Aya Mahfouz wrote:
> Replaces IS_PO2 by is_power_of_2. It is more accurate to use
> is_power_of_2 since it returns 1 for numbers that are powers
> of 2 only whereas IS_PO2 returns 1 for 0 and numbers that are
> powers of 2.
>
> Reviewed-by: Andreas Dilger <andreas.dilger at intel.com>
> Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal at gmail.com>
> ---
> v2:
> -changed commit message
> -added Andreas Reviewed by tag
>
> drivers/staging/lustre/lustre/libcfs/hash.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/libcfs/hash.c b/drivers/staging/lustre/lustre/libcfs/hash.c
> index 6f4c7d4..4b5e79a 100644
> --- a/drivers/staging/lustre/lustre/libcfs/hash.c
> +++ b/drivers/staging/lustre/lustre/libcfs/hash.c
> @@ -109,6 +109,8 @@
>
> #include "../../include/linux/libcfs/libcfs.h"
> #include <linux/seq_file.h>
> +#include <linux/log2.h>
> +
This extra blank line will introduce new checkpatch error of "multiple
blank lines"
regards
sudip
More information about the lustre-devel
mailing list