[lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions
Dan Carpenter
dan.carpenter at oracle.com
Mon Dec 5 14:06:47 PST 2016
Sorry, I was unclear. I have no problem with white space changes on
their own or when they are on the same line as something else you're
changing.
What I meant is that when you're just moving functions around then don't
mix unrelated white space changes into that patch. I have automated
scripts for reviewing moving code around but slight changes mean that I
have to review it manually line by line to spot the difference. I can
review a one liner cleanup in about 10 seconds but it's finding the line
which changed that's the problem in this case.
And I'm also fine with this patch since I already reviewed it, but in
the future, please avoid the temptation to do cleanups until after.
regards,
dan carpenter
More information about the lustre-devel
mailing list