[lustre-devel] [PATCH 1/1] staging: lustre: lnet: fix improper return value
Oleg Drokin
oleg.drokin at intel.com
Mon Dec 5 14:44:09 PST 2016
On Dec 3, 2016, at 7:52 AM, Pan Bian wrote:
> From: Pan Bian <bianpan2016 at 163.com>
>
> At the end of function lstcon_group_info(), "return 0" seems improper.
> It may be better to return the value of rc.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188811
>
> Signed-off-by: Pan Bian <bianpan2016 at 163.com>
Acked-by: Oleg Drokin <oleg.drokin at intel.com>
> ---
> drivers/staging/lustre/lnet/selftest/console.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lnet/selftest/console.c b/drivers/staging/lustre/lnet/selftest/console.c
> index a0fcbf3..9a7c41a 100644
> --- a/drivers/staging/lustre/lnet/selftest/console.c
> +++ b/drivers/staging/lustre/lnet/selftest/console.c
> @@ -820,7 +820,7 @@
>
> lstcon_group_decref(grp);
>
> - return 0;
> + return rc;
> }
>
> static int
> --
> 1.9.1
>
More information about the lustre-devel
mailing list