[lustre-devel] [PATCH] staging: lustre: fixed shadowed variable in socklnd_cb.c
andrew.kanner at gmail.com
Thu Nov 3 15:22:20 PDT 2016
2016-11-04 1:12 GMT+03:00 Dilger, Andreas <andreas.dilger at intel.com>:
> On Nov 3, 2016, at 15:54, Andrew Kanner <andrew.kanner at gmail.com> wrote:
>> Changed variable 'tx' name in local scope
>> Fixed: sparse warning:
>> socklnd_cb.c:2476:41: warning: symbol 'tx' shadows an earlier one
>> socklnd_cb.c:2435:25: originally declared here
> Looking at this more closely (or from a greater distance, hard to say),
> the outer-scope "tx" is used only after this inner-scope "tx", so in
> fact there is no benefit to having the inner-scope declaration at all.
> Removing it may save a stack variable (depending on how the compiler
> optimizes), and shouldn't affect functionality.
> Cheers, Andreas
I see, I'll correct it and resend as PATCH v2. Thank you.
More information about the lustre-devel