[lustre-devel] [PATCH v2 1/2] staging: lustre: remove broken dead code in cfs_cpt_table_create_pattern
arnd at arndb.de
Thu Oct 27 06:36:04 PDT 2016
On Thursday, October 27, 2016 3:12:42 PM CEST Greg Kroah-Hartman wrote:
> On Tue, Oct 25, 2016 at 11:22:30PM +0200, Arnd Bergmann wrote:
> > After a recent bugfix, we get a warning about the use of an uninitialized
> > variable:
> > drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c: In function 'cfs_cpt_table_create_pattern':
> > drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c:833:7: error: 'str' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> > This part of the function used to not do anything as we would reassign
> > the 'str' pointer to something else right away, but now we pass an
> > uninitialized pointer into 'strchr', which can cause a kernel page fault
> > or worse.
> > Fixes: 239fd5d41f9b ("staging: lustre: libcfs: shortcut to create CPT from NUMA topology")
> > Signed-off-by: Arnd Bergmann <arnd at arndb.de>
> > ---
> > drivers/staging/lustre/lnet/libcfs/linux/linux-cpu.c | 7 -------
> > 1 file changed, 7 deletions(-)
> Hm, I already applied the v1 versions of these, right? What changed
> with these, they seem identical to me...
The patches you applied were fine, they just had not made it into linux-next
by Tuesday, and I thought they got lost as I had sent them as part of a longer
series and I screwed up one of the two changelogs initially (you applied the
fixed v2 patch I sent immediately afterwards).
Sorry about the confusion.
More information about the lustre-devel