[lustre-devel] [PATCH 3/3] staging: lustre: obdclass: fix checking for obd_init_checks()

Dan Carpenter dan.carpenter at oracle.com
Fri Aug 25 23:04:46 PDT 2017


The obd_init_checks() function can either return -EOVERFLOW or -EINVAL
but we accidentally ignore -EINVAL returns.

Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
---
This patch is the right thing, but it's always a bit risky turning on
new checks and I haven't tested this.

diff --git a/drivers/staging/lustre/lustre/obdclass/class_obd.c b/drivers/staging/lustre/lustre/obdclass/class_obd.c
index 545358923271..2df218b010e1 100644
--- a/drivers/staging/lustre/lustre/obdclass/class_obd.c
+++ b/drivers/staging/lustre/lustre/obdclass/class_obd.c
@@ -448,7 +448,7 @@ static int __init obdclass_init(void)
 	obd_zombie_impexp_init();
 
 	err = obd_init_checks();
-	if (err == -EOVERFLOW)
+	if (err)
 		return err;
 
 	class_init_uuidlist();


More information about the lustre-devel mailing list