[lustre-devel] [PATCH] drivers: staging/lustre: conrpc.c - fix sparse error: incompatible types in comparison expression (different address spaces)

Tordek kedrot at gmail.com
Thu Jun 1 11:56:44 PDT 2017


This is fairly minor but it reveals a few hidden warnings, could I get some
feedback on it?

Thanks
--
Guillermo

On 5 May 2017 10:53, "Tordek" <kedrot at gmail.com> wrote:

> This patch makes a lot of new warnings pop up, because the error is
> blocking the rest of the file from being processed.
>
> On 5 May 2017 at 10:51, Guillermo O. Freschi <kedrot at gmail.com> wrote:
> > Signed-off-by: Guillermo O. Freschi <kedrot at gmail.com>
> > ---
> >  drivers/staging/lustre/lnet/selftest/conrpc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/lustre/lnet/selftest/conrpc.c
> b/drivers/staging/lustre/lnet/selftest/conrpc.c
> > index da36c55b86d3..f4578200994f 100644
> > --- a/drivers/staging/lustre/lnet/selftest/conrpc.c
> > +++ b/drivers/staging/lustre/lnet/selftest/conrpc.c
> > @@ -487,7 +487,7 @@ lstcon_rpc_trans_interpreter(struct
> lstcon_rpc_trans *trans,
> >                                    sizeof(struct list_head)))
> >                         return -EFAULT;
> >
> > -               if (tmp.next == head_up)
> > +               if ((struct list_head __user *)tmp.next == head_up)
> >                         return 0;
> >
> >                 next = tmp.next;
> > --
> > 2.11.0
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lustre.org/pipermail/lustre-devel-lustre.org/attachments/20170601/e759a8cd/attachment.htm>


More information about the lustre-devel mailing list