[lustre-devel] [PATCH v2] staging: lustre: llite: Replace the symbolic file permission mode with the numeric one
Roman Storozhenko
romeusmeister at gmail.com
Sat Jun 10 04:48:34 PDT 2017
Replaces S_IRWXUGO with 0777. The reason is that symbolic permissions
considered harmful:
https://lwn.net/Articles/696229/
The second version of that patch fixes the mistype in the first version.
There were "0007" in the description instead of correct "0777" value.
Thanks to Cory Spitz, who pointed out this error here:
http://lists.lustre.org/pipermail/lustre-devel-lustre.org/2017-June/005726.html
Signed-off-by: Roman Storozhenko <romeusmeister at gmail.com>
---
drivers/staging/lustre/lustre/llite/dir.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/llite/dir.c b/drivers/staging/lustre/lustre/llite/dir.c
index 13b3592..de5b4bf 100644
--- a/drivers/staging/lustre/lustre/llite/dir.c
+++ b/drivers/staging/lustre/lustre/llite/dir.c
@@ -1141,7 +1141,7 @@ static long ll_dir_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
}
#if OBD_OCD_VERSION(2, 9, 50, 0) > LUSTRE_VERSION_CODE
- mode = data->ioc_type != 0 ? data->ioc_type : S_IRWXUGO;
+ mode = data->ioc_type != 0 ? data->ioc_type : 0777;
#else
mode = data->ioc_type;
#endif
--
2.7.4
More information about the lustre-devel
mailing list