[lustre-devel] [PATCH] lustre: don't set f_version in ll_readdir

[Dilger, Andreas]

On Oct 30, 2017, at 23:00, Jeff Layton <jlayton at kernel.org> wrote:
> 
> From: Jeff Layton <jlayton at redhat.com>
> 
> f_version is only ever used by filesystem-specific code. Generic
> VFS code never uses it.
> 
> Nothing in lustre ever looks at it, so just remove this.
> 
> Signed-off-by: Jeff Layton <jlayton at redhat.com>

Reviewed-by: Andreas Dilger <andreas.dilger at intel.com>

> ---
> drivers/staging/lustre/lustre/llite/dir.c | 3 ---
> 1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/staging/lustre/lustre/llite/dir.c b/drivers/staging/lustre/lustre/llite/dir.c
> index 1db3e7f345c5..9664447ffcd7 100644
> --- a/drivers/staging/lustre/lustre/llite/dir.c
> +++ b/drivers/staging/lustre/lustre/llite/dir.c
> @@ -367,8 +367,6 @@ static int ll_readdir(struct file *filp, struct dir_context *ctx)
> 	}
> 	ctx->pos = pos;
> 	ll_finish_md_op_data(op_data);
> -	filp->f_version = inode->i_version;
> -
> out:
> 	if (!rc)
> 		ll_stats_ops_tally(sbi, LPROC_LL_READDIR, 1);
> @@ -1675,7 +1673,6 @@ static loff_t ll_dir_seek(struct file *file, loff_t offset, int origin)
> 			else
> 				fd->lfd_pos = offset;
> 			file->f_pos = offset;
> -			file->f_version = 0;
> 		}
> 		ret = offset;
> 	}
> -- 
> 2.13.6
> 

Cheers, Andreas
--
Andreas Dilger
Lustre Principal Architect
Intel Corporation