[lustre-devel] [PATCH] lustre: ptlrpc: kfree used instead of kvfree
Greg Kroah-Hartman
gregkh at linuxfoundation.org
Fri Sep 1 22:40:21 PDT 2017
On Fri, Sep 01, 2017 at 08:13:18PM +0000, Dilger, Andreas wrote:
> On Aug 31, 2017, at 16:55, Nadav Amit <namit at vmware.com> wrote:
> >
> > rq_reqbuf is allocated using kvmalloc() but released in one occasion
> > using kfree() instead of kvfree().
> >
> > The issue was found using grep based on a similar bug.
> >
> > Fixes: d7e09d0397e8 ("add Lustre file system client support")
>
> It would appear that this bug was introduced by ee0ec1946ec2
> "lustre: ptlrpc: Replace uses of OBD_{ALLOC,FREE}_LARGE", but
> it looks like the problem predates this patch, since it was
> originally using OBD_FREE() instead of OBD_FREE_LARGE() here
> so the Coccinelle script wouldn't have caught the issue.
>
> Reviewed-by: Andreas Dilger <andreas.dilger at intel.com>
>
> >
> > Cc: Peng Tao <bergwolf at gmail.com>
> > Cc: Oleg Drokin <oleg.drokin at intel.com>
> > Cc: Andreas Dilger <andreas.dilger at intel.com>
> > Cc: James Simmons <jsimmons at infradead.org>
> >
> > Signed-off-by: Nadav Amit <namit at vmware.com>
> > ---
> > drivers/staging/lustre/lustre/ptlrpc/sec.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
Can a lustre maintainer resend this in a format that I can apply it in?
thanks,
greg k-h
More information about the lustre-devel
mailing list