[lustre-devel] [PATCH 0/6] lustre: convert list_for_each() to list_for_each_entry()

James Simmons jsimmons at infradead.org
Wed Aug 1 20:16:06 PDT 2018


> list_for_each_entry(foo) is generally preferred to
>   list_for_each(l,...)
>      foo = list_entry(l,...)
> 
> as there is less noise in the code.
> The first patch contains seveveral trivial conversions.
> The remaining patches are less obvious and are separate
> so they are easier to review.
> 
> NeilBrown
> 
> The following series implements...

Looks good and testing shows no problems. I will poke the LNet
guys to look at these as well.
 
> ---
> 
> NeilBrown (6):
>       lustre: convert list_for_each() to list_for_each_entry().
>       lustre: lnet/config: convert list_for_each to list_for_each_entry
>       lustre: convert list_for_each in ksocknal_create_routes
>       lustre: convert list_for_each in ksocknal_close_conn_locked()
>       lustre: convert list_for_each() in ksocknal_push_peer()
>       lustre: convert list_for_each() in ksocknal_debug_peerhash()
> 
> 
>  .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c    |   17 --
>  .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c |   20 +-
>  .../staging/lustre/lnet/klnds/socklnd/socklnd.c    |  166 +++++++-------------
>  .../staging/lustre/lnet/klnds/socklnd/socklnd_cb.c |   20 +-
>  drivers/staging/lustre/lnet/lnet/api-ni.c          |   29 +--
>  drivers/staging/lustre/lnet/lnet/config.c          |   28 +--
>  drivers/staging/lustre/lnet/lnet/lib-move.c        |    9 -
>  drivers/staging/lustre/lnet/lnet/router.c          |   47 +-----
>  drivers/staging/lustre/lnet/selftest/conrpc.c      |    7 -
>  drivers/staging/lustre/lustre/obdclass/genops.c    |    4 
>  .../staging/lustre/lustre/obdecho/echo_client.c    |    4 
>  11 files changed, 99 insertions(+), 252 deletions(-)
> 
> --
> Signature
> 
> 


More information about the lustre-devel mailing list