[lustre-devel] [PATCH 01/38] lustre: llite: rename ldebugfs_[un]register_mountpoint
NeilBrown
neilb at suse.com
Thu Aug 16 21:24:09 PDT 2018
On Thu, Aug 16 2018, James Simmons wrote:
> Rename from ldebugfs_[un]register_mountpoint() to
> ll_debugfs_[un]register_super().
I really helps with review if I am told *why* something is happening.
I can guess, but being told means I'm less concerned that I might have
missed something.
I can see that "mountpoint" is an inappropriate name, though I'm not
entired sure that "super" is a better now. Surely this code is
registering an filesystem (instance) with debugfs.... maybe a "super" is
exactly a "filesystem instance"....
Why is ll_debugfs better than ldebugfs? More typing doesn't usually
thrill me.
I don't really care about this particular change - it seems innocuous.
I do really care about good change logs.
Thanks,
NeilBrown
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.lustre.org/pipermail/lustre-devel-lustre.org/attachments/20180817/81ed97d5/attachment-0001.sig>
More information about the lustre-devel
mailing list