[lustre-devel] [bug report] staging: lustre: replace simple cases of LIBCFS_ALLOC with kzalloc.

Dan Carpenter dan.carpenter at oracle.com
Tue Jan 16 00:12:08 PST 2018

On Mon, Jan 15, 2018 at 06:27:26PM +0000, Eremin, Dmitry wrote:
> Hello Dan,
> The function kiblnd_destroy_conn() is conditionally free the conn pointer.
> void kiblnd_destroy_conn(kib_conn_t *conn, bool free_conn)
> {
> […]
>                 if (free_conn)
>                                LIBCFS_FREE(conn, sizeof(*conn));

This check is not there in the kernel.org kernel.  In the upstream
kernel it frees it unconditionally.  The "free_conn" parameter was added
in commit 4d99b2581eff ("staging: lustre: avoid intensive reconnecting
for ko2iblnd") but that line must have been left out.

dan carpenter

More information about the lustre-devel mailing list