[lustre-devel] [PATCH 0/5] lnet: reduce code in lib-socket

[James Simmons]

> lib-socket contains code to iterate over network interfaces and
> determine the IPv4 address of each.  It does this but using
> socket-ioctls.
> There are more direct interfaces within the kernel for
> accessing this information, so change to use those directly.

With an updated based on Doug's reviewer to check the return value
I give this a positive review for the patch series.

Reviewed-by: James Simmons <jsimmons at infradead.org>

> ---
> 
> NeilBrown (5):
>       lustre: socklnd: use for_each_netdev() instead of lnet_ipif_enumerate()
>       lustre: socklnd: use ksocknal_enumerate_interfaces for individual interfaces.
>       lustre: change lnet_ipaddr_enumerate() to use for_each_netdev()
>       lustre: o2iblnd: get IP address more directly.
>       lustre: lnet: remove lnet_ipif_enumerate()
> 
> 
>  .../staging/lustre/include/linux/lnet/lib-lnet.h   |    3 
>  .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c    |   48 +++--
>  .../staging/lustre/lnet/klnds/socklnd/socklnd.c    |   96 ++++-----
>  drivers/staging/lustre/lnet/lnet/config.c          |   78 +++----
>  drivers/staging/lustre/lnet/lnet/lib-socket.c      |  211 --------------------
>  5 files changed, 103 insertions(+), 333 deletions(-)
> 
> --
> Signature
> 
>