[lustre-devel] [PATCH 00/24] lustre - more cleanups including module reduction.

[NeilBrown]

On Tue, Jun 26 2018, Patrick Farrell wrote:

> Ah, sorry, lost your mail in the shuffle, Neil.
>
> The name, mostly.  ptlrpc is one subdirectory and one subsystem, so I don’t want to use it for a module that explicitly includes all of several.  I’m not sure of a better name immediately - is this module intended to be shared between client and server?
>

Thanks for clarifying.
Note that I'm still feeling my way around here so "intended" can at most
be a soft intention, open to change.  But yes, I expect this module
would ultimately be shared with the server.

I think things should only be in different modules if it might sometimes
make sense to use one without the other.

So everything that is always used for a lustre client mount, and is only
used for a lustre client mount, should be in a module called "lustre".
And everything always and only used for a lustre server should be in a
module called (something like) "lustre-server".

It appears to me that ptlrpc, ldlm, and obdclass are always and only
used together, but can be used for client or server.  So I think they
should be together in a module.
I'm tempted to add lnet to that list.  There has been mention that cray
has some other functionality that uses lnet - if that doesn't use
ptlrpc, then maybe that is a case for keeping lnet separate.  However I
would rather see it as a potential case to separate lnet from the others
at a later date if that functionality from cray ever goes into mainline.

The klnds modules can presumably be used independently(?) so they can
sensibly remain as separate modules, though I'm beginning to wonder if
lnet can actually function without socklnd, so I wonder if that should
be permanently part of the lnet module (with NFS, the xprt_sock code is
a permanent part of "sunrpc", while the xprt_rdma (aka rpcrdma) code
can be a separate module).

In the interests of a concrete strawman, what objections would I get if
I suggested that ptlrpc, ldlm, obdclass, lnet, and socklnd were all included in
the one module named "lnet" ??

Thanks,
NeilBrown
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.lustre.org/pipermail/lustre-devel-lustre.org/attachments/20180627/02d56082/attachment.sig>