[lustre-devel] [PATCH 1/9] lustre: obdclass: fix formating of connection flags
James Simmons
jsimmons at infradead.org
Sun Nov 25 17:30:01 PST 2018
> The current code puts the separator *only*
> at the start rather than *never* at the start.
Reviewed-by: James Simmons <jsimmons at infradead.org>y
> Signed-off-by: NeilBrown <neilb at suse.com>
> ---
> .../lustre/lustre/obdclass/lprocfs_status.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
> index feba2ef5a3bc..acfea7a44350 100644
> --- a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
> +++ b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
> @@ -709,14 +709,14 @@ static void obd_connect_seq_flags2str(struct seq_file *m, u64 flags,
> for (i = 0, mask = 1; i < 64; i++, mask <<= 1) {
> if (flags & mask) {
> seq_printf(m, "%s%s",
> - first ? sep : "", obd_connect_names[i]);
> + first ? "" : sep, obd_connect_names[i]);
> first = false;
> }
> }
>
> if (flags & ~(mask - 1)) {
> seq_printf(m, "%sunknown flags %#llx",
> - first ? sep : "", flags & ~(mask - 1));
> + first ? "" : sep, flags & ~(mask - 1));
> first = false;
> }
>
>
>
>
More information about the lustre-devel
mailing list