[lustre-devel] [PATCH 4/9] lustre: rename: DNE2 should return -EXDEV upon remote rename

NeilBrown neilb at suse.com
Sun Nov 25 19:00:59 PST 2018


On Mon, Nov 26 2018, James Simmons wrote:

> On Fri, 23 Nov 2018, NeilBrown wrote:
>
>> From: Lai Siyao <lai.siyao at intel.com>
>> 
>> DNE2 MDS should return -EXDEV upon remote rename, so that old
>> client can do rename with copy and delete, instead of fail
>> with -EREMOTE.
>
> Let me guess you were debugging the migration failures and fould this :-)
> I was doing the same thing.

Nope - I was just looking though all the missing patches to see if
anything was relevant. :-)

Thanks for all the "Reviewed-by"s !

NeilBrown

>
> Reviewed-by: James Simmons <jsimmons at infradead.org>
>  
>> Signed-off-by: Lai Siyao <lai.siyao at intel.com>
>> Change-Id: I68e8e99259065922f31bee5343be309380715674
>> WC-bug-id: https://jira.whamcloud.com/browse/LU-6660
>> Reviewed-on: http://review.whamcloud.com/15323
>> Reviewed-by: Andreas Dilger <andreas.dilger at intel.com>
>> Reviewed-by: wangdi <di.wang at intel.com>
>> Reviewed-by: Fan Yong <fan.yong at intel.com>
>> Signed-off-by: NeilBrown <neilb at suse.com>
>> ---
>>  drivers/staging/lustre/lustre/lmv/lmv_obd.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/staging/lustre/lustre/lmv/lmv_obd.c b/drivers/staging/lustre/lustre/lmv/lmv_obd.c
>> index 32bb9fca88c9..7e4ffeb15a63 100644
>> --- a/drivers/staging/lustre/lustre/lmv/lmv_obd.c
>> +++ b/drivers/staging/lustre/lustre/lmv/lmv_obd.c
>> @@ -1945,7 +1945,7 @@ static int lmv_rename(struct obd_export *exp, struct md_op_data *op_data,
>>  	}
>>  
>>  	rc = md_rename(target_exp, op_data, old, oldlen, new, newlen, request);
>> -	if (rc && rc != -EREMOTE)
>> +	if (rc && rc != -EXDEV)
>>  		return rc;
>>  
>>  	body = req_capsule_server_get(&(*request)->rq_pill, &RMF_MDT_BODY);
>> 
>> 
>> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.lustre.org/pipermail/lustre-devel-lustre.org/attachments/20181126/7da77410/attachment.sig>


More information about the lustre-devel mailing list