[lustre-devel] [PATCH] lustre: accept suffix when parsing max_pages_per_rpc
NeilBrown
neilb at suse.com
Thu Oct 25 20:33:55 PDT 2018
upstream lustre allows size suffixes (K, M, G, etc) for
max_pages_per_rpc. We should too.
Signed-off-by: NeilBrown <neilb at suse.com>
---
This fixes test 101g.
drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
index edac88440b41..feba2ef5a3bc 100644
--- a/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
+++ b/drivers/staging/lustre/lustre/obdclass/lprocfs_status.c
@@ -1868,11 +1868,12 @@ ssize_t max_pages_per_rpc_store(struct kobject *kobj, struct attribute *attr,
struct obd_connect_data *ocd;
unsigned long long val;
int chunk_mask;
+ char *endp;
int rc;
- rc = kstrtoull(buffer, 10, &val);
- if (rc)
- return rc;
+ val = memparse(buffer, &endp);
+ if (*endp)
+ return -EINVAL;
/* if the max_pages is specified in bytes, convert to pages */
if (val >= ONE_MB_BRW_SIZE)
--
2.14.0.rc0.dirty
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.lustre.org/pipermail/lustre-devel-lustre.org/attachments/20181026/9c53a85c/attachment.sig>
More information about the lustre-devel
mailing list