[lustre-devel] [PATCH 00/34] Beginning of multi-rail support for drivers/staging/lustre

James Simmons jsimmons at infradead.org
Sat Sep 29 15:35:19 PDT 2018


> > Signed-off-by: Amir Shehata <ashehata at whamcloud.com>
> > WC-bug-id: https://jira.whamcloud.com/browse/LU-7734
> > Reviewed-on: http://review.whamcloud.com/18274
> > Reviewed-by: Doug Oucharek <dougso at me.com>
> > Reviewed-by: Olaf Weber <olaf.weber at hpe.com>
> > Signed-off-by: NeilBrown <neilb at suse.com>
> 
> Thanks for the suggestion.  I don't like that approach exactly because
> it seems to be a lie.  The specific patch was not reviewed by those
> people, and there is useful information which is not included there.
> I have changed to patches to include:
> 
>     This is part of
>         Commit: 8cbb8cd3e771 ("LU-7734 lnet: Multi-Rail local NI split")
>     from upstream lustre, where it is marked:
>         Signed-off-by: Amir Shehata <amir.shehata at intel.com>
>         WC-bug-id: https://jira.whamcloud.com/browse/LU-7734
>         Reviewed-on: http://review.whamcloud.com/18274
>         Reviewed-by: Doug Oucharek <doug.s.oucharek at intel.com>
>         Reviewed-by: Olaf Weber <olaf at sgi.com>
> 
> checkpatch is not happy with the indented tags, but checkpatch is a
> servant, not the master.

To my knowledge their isn't really a policy about this. What I have been
doing is kind of following how LTS versions of lustre have been handled. 
For LTS versions patches are cherry-picked and two additional lines are
added:

Lustre-change:
Lustre-commit:

The orginal reviews are keep. Also by including the original reviews the
people involved with those patches are poked. The only requirement is that
2 people review again. Not everyone has to review for it to land. Once 
landed I don't see a clear why to tell who reviewed.

In any case the above approach seems reasonable as long as the original
author is preserve. The general rule is the original patch poster normally
keeps authorship. Also I noticed patches recently pushed are not reaching
the original authors and reviewers. We should make sure that still 
happens.




More information about the lustre-devel mailing list