[lustre-devel] [PATCH 24/37] lustre: lu_object: remove extra newline from debug printing.
James Simmons
jsimmons at infradead.org
Sun Feb 24 11:08:45 PST 2019
> In lu_cdebug_printer(), is "complete" is true, then
> key->lck_area ends with a newline, so there is no need to
> include on in the format too.
We thought we found all those extra or missing newlines. Thanks
for finding it.
Reviewed-by: James Simmons <jsimmons at infradead.org>
> Signed-off-by: NeilBrown <neilb at suse.com>
> ---
> drivers/staging/lustre/lustre/obdclass/lu_object.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/lustre/lustre/obdclass/lu_object.c b/drivers/staging/lustre/lustre/obdclass/lu_object.c
> index d4f1eddd96ca..3e23babb329a 100644
> --- a/drivers/staging/lustre/lustre/obdclass/lu_object.c
> +++ b/drivers/staging/lustre/lustre/obdclass/lu_object.c
> @@ -526,7 +526,7 @@ int lu_cdebug_printer(const struct lu_env *env,
> ARRAY_SIZE(key->lck_area) - used, format, args);
> if (complete) {
> if (cfs_cdebug_show(msgdata->msg_mask, msgdata->msg_subsys))
> - libcfs_debug_msg(msgdata, "%s\n", key->lck_area);
> + libcfs_debug_msg(msgdata, "%s", key->lck_area);
> key->lck_area[0] = 0;
> }
> va_end(args);
>
>
>
More information about the lustre-devel
mailing list