[lustre-devel] [PATCH 10/37] lustre: kernelcomm: pass correct gfp_t to kmalloc.

[Andreas Dilger]

On Feb 24, 2019, at 09:05, James Simmons <jsimmons at infradead.org> wrote:
> 
> 
>> Passing 0 as the gfp_t for kmalloc() is not meaningful, and
>> could change behaviour.
>> Use an explicit GFP_KERNEL instead.
> 
> Why did it every do this ??????

This is a defect introduced by commit 1b254784381 "LU-1346 libcfs: replace cfs_ memory wrappers".
It replaced cfs_alloc(), which internally supplied the GFP_* mask with kmalloc(), which does not.

Cheers, Andreas
---
Andreas Dilger
Principal Lustre Architect
Whamcloud