[lustre-devel] [PATCH 27/37] lustre: discard lu_ref

NeilBrown neilb at suse.com
Tue Feb 26 17:17:41 PST 2019


On Sun, Feb 24 2019, James Simmons wrote:

>> struct lu_ref is always an empty structure, and the functions
>> which manipulate it do nothing.
>> So this is not being tested and so cannot be trusted.
>> So remove all these calls and field declarations.
>
> Or we can make lu_ref really work and always test with it :-)

We could ... though a lot of the code has been removed already, I was
just finishing the job.

How useful is this stuff?
Has it actually helped to find any bugs?
Does it do any run-time checks, or it is just
there to help you pull apart a crash-dump?

I think there is a real cost in having these extra linkages.  I'd like
to be clear what the benefit is.

Thanks,
NeilBrown
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.lustre.org/pipermail/lustre-devel-lustre.org/attachments/20190227/07a96103/attachment.sig>


More information about the lustre-devel mailing list