[lustre-devel] [PATCH 05/10] lustre: don't declare extern variables in C files.
James Simmons
jsimmons at infradead.org
Sun Jul 21 19:12:17 PDT 2019
From: NeilBrown <neilb at suse.com>
'extern' declarations should only appear in .h files.
All these names are declared in .h files as needed,
and these duplicate declarations in .c files can
be removed.
Signed-off-by: NeilBrown <neilb at suse.com>
WC-bug-id: https://jira.whamcloud.com/browse/LU-4423
Reviewed-on: https://review.whamcloud.com/35294
Reviewed-by: Andreas Dilger <adilger at whamcloud.com>
Reviewed-by: Arshad Hussain <arshad.super at gmail.com>
Reviewed-by: Petros Koutoupis <pkoutoupis at cray.com>
Signed-off-by: James Simmons <jsimmons at infradead.org>
---
fs/lustre/ldlm/ldlm_resource.c | 2 --
fs/lustre/ptlrpc/import.c | 1 -
fs/lustre/ptlrpc/ptlrpc_module.c | 5 -----
3 files changed, 8 deletions(-)
diff --git a/fs/lustre/ldlm/ldlm_resource.c b/fs/lustre/ldlm/ldlm_resource.c
index 45b2e97..372a290 100644
--- a/fs/lustre/ldlm/ldlm_resource.c
+++ b/fs/lustre/ldlm/ldlm_resource.c
@@ -681,8 +681,6 @@ struct ldlm_namespace *ldlm_namespace_new(struct obd_device *obd, char *name,
}
EXPORT_SYMBOL(ldlm_namespace_new);
-extern struct ldlm_lock *ldlm_lock_get(struct ldlm_lock *lock);
-
/**
* Cancel and destroy all locks on a resource.
*
diff --git a/fs/lustre/ptlrpc/import.c b/fs/lustre/ptlrpc/import.c
index d49707a..67a66a5 100644
--- a/fs/lustre/ptlrpc/import.c
+++ b/fs/lustre/ptlrpc/import.c
@@ -1572,7 +1572,6 @@ int ptlrpc_disconnect_import(struct obd_import *imp, int noclose)
EXPORT_SYMBOL(ptlrpc_disconnect_import);
/* Adaptive Timeout utils */
-extern unsigned int at_min, at_max, at_history;
/*
*Update at_current with the specified value (bounded by at_min and at_max),
diff --git a/fs/lustre/ptlrpc/ptlrpc_module.c b/fs/lustre/ptlrpc/ptlrpc_module.c
index f73ba41..6888df9 100644
--- a/fs/lustre/ptlrpc/ptlrpc_module.c
+++ b/fs/lustre/ptlrpc/ptlrpc_module.c
@@ -40,11 +40,6 @@
#include "ptlrpc_internal.h"
-extern spinlock_t ptlrpc_last_xid_lock;
-#if RS_DEBUG
-extern spinlock_t ptlrpc_rs_debug_lock;
-#endif
-
DEFINE_MUTEX(ptlrpc_startup);
static int ptlrpc_active;
--
1.8.3.1
More information about the lustre-devel
mailing list