[lustre-devel] [PATCH 500/622] lnet: eliminate uninitialized warning

James Simmons jsimmons at infradead.org
Thu Feb 27 13:16:08 PST 2020


From: Wang Shilong <wshilong at ddn.com>

lustre-release/net/lnet/lnet/router.c: In funciton 'lnet_del_route':
include/linux/compiler.h:177:26: error: 'lp' may be used uninitialized
in this function [-Werror=maybe-uninitialized]
  case 8: *(__u64 *)res = *(volatile __u64 *)p; break;  \

lustre-release/net/lnet/lnet/router.c:754:20: note: 'lp' was declared here
  struct lnet_peer *lp;

lustre-release/net/lnet/lnet/router.c: At top level:
cc1: error: unrecognized command line option '-Wno-stringop-overflow' [-Werror]
cc1: error: unrecognized command line option '-Wno-stringop-truncation' [-Werror]
cc1: error: unrecognized command line option '-Wno-format-truncation' [-Werror]
cc1: all warnings being treated as errors

codes logic gurantee @lpi and @lpni are inited at the same time,
but let's init @lpi to make gcc happy.

WC-bug-id: https://jira.whamcloud.com/browse/LU-12764
Lustre-commit: a8fbaa1b998f ("LU-12764 lnet: eliminate uninitialized warning")
Signed-off-by: Wang Shilong <wshilong at ddn.com>
Reviewed-on: https://review.whamcloud.com/36189
Reviewed-by: Andreas Dilger <adilger at whamcloud.com>
Reviewed-by: Li Dongyang <dongyangli at ddn.com>
Reviewed-by: Oleg Drokin <green at whamcloud.com>
Signed-off-by: James Simmons <jsimmons at infradead.org>
---
 net/lnet/lnet/router.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/lnet/lnet/router.c b/net/lnet/lnet/router.c
index a5e4af0..447706d 100644
--- a/net/lnet/lnet/router.c
+++ b/net/lnet/lnet/router.c
@@ -721,7 +721,7 @@ static void lnet_shuffle_seed(void)
 	struct lnet_peer_ni *lpni;
 	struct lnet_route *route;
 	struct list_head zombies;
-	struct lnet_peer *lp;
+	struct lnet_peer *lp = NULL;
 	int i = 0;
 
 	INIT_LIST_HEAD(&rnet_zombies);
-- 
1.8.3.1



More information about the lustre-devel mailing list