[lustre-devel] [PATCH 29/41] lustre: llite: remove unused ll_teardown_mmaps()

James Simmons jsimmons at infradead.org
Mon Apr 5 00:50:58 PST 2021


From: Andreas Dilger <adilger at whamcloud.com>

The ll_teardown_mmaps() function is no longer used and can be
removed.

Fixes: d5419b40599b ("lustre: use generic_error_remove_page()")
WC-bug-id: https://jira.whamcloud.com/browse/LU-12477
Lustre-commit: 647c96562b27cef ("LU-12477 llite: remove unused ll_teardown_mmaps()")
Signed-off-by: Andreas Dilger <adilger at whamcloud.com>
Reviewed-on: https://review.whamcloud.com/41086
Reviewed-by: James Simmons <jsimmons at infradead.org>
Reviewed-by: Neil Brown <neilb at suse.de>
Reviewed-by: Oleg Drokin <green at whamcloud.com>
Signed-off-by: James Simmons <jsimmons at infradead.org>
---
 fs/lustre/llite/llite_internal.h |  1 -
 fs/lustre/llite/llite_mmap.c     | 17 -----------------
 2 files changed, 18 deletions(-)

diff --git a/fs/lustre/llite/llite_internal.h b/fs/lustre/llite/llite_internal.h
index 0fe0b562..3bd774b 100644
--- a/fs/lustre/llite/llite_internal.h
+++ b/fs/lustre/llite/llite_internal.h
@@ -1265,7 +1265,6 @@ void ll_io_init(struct cl_io *io, const struct file *file, int write,
 
 /* llite/llite_mmap.c */
 
-int ll_teardown_mmaps(struct address_space *mapping, u64 first, u64 last);
 int ll_file_mmap(struct file *file, struct vm_area_struct *vma);
 void policy_from_vma(union ldlm_policy_data *policy, struct vm_area_struct *vma,
 		     unsigned long addr, size_t count);
diff --git a/fs/lustre/llite/llite_mmap.c b/fs/lustre/llite/llite_mmap.c
index b9a73e0..0963757 100644
--- a/fs/lustre/llite/llite_mmap.c
+++ b/fs/lustre/llite/llite_mmap.c
@@ -511,23 +511,6 @@ static void ll_vm_close(struct vm_area_struct *vma)
 	pcc_vm_close(vma);
 }
 
-/* XXX put nice comment here.  talk about __free_pte -> dirty pages and
- * nopage's reference passing to the pte
- */
-int ll_teardown_mmaps(struct address_space *mapping, u64 first, u64 last)
-{
-	int rc = -ENOENT;
-
-	LASSERTF(last > first, "last %llu first %llu\n", last, first);
-	if (mapping_mapped(mapping)) {
-		rc = 0;
-		unmap_mapping_range(mapping, first + PAGE_SIZE - 1,
-				    last - first + 1, 0);
-	}
-
-	return rc;
-}
-
 static const struct vm_operations_struct ll_file_vm_ops = {
 	.fault			= ll_fault,
 	.page_mkwrite		= ll_page_mkwrite,
-- 
1.8.3.1



More information about the lustre-devel mailing list