[lustre-devel] [PATCH 04/41] lustre: llite: quiet spurious ioctl warning

James Simmons jsimmons at infradead.org
Mon Apr 5 00:50:33 PST 2021


From: Andreas Dilger <adilger at whamcloud.com>

Calling "lfs setstripe" prints a suprious warning about using the old
ioctl(LL_IOC_LOV_GETSTRIPE) when that is not actually the case.

Remove the ioctl warning for now and deal with related issues later.

Fixes: 1288417cb488 ("lustre: llite: restore ll_file_getstripe in ll_lov_setstripe")
WC-bug-id: https://jira.whamcloud.com/browse/LU-14316
Lustre-commit: c6f65d8af11647 ("LU-14316 llite: quiet spurious ioctl warning")
Signed-off-by: Andreas Dilger <adilger at whamcloud.com>
Reviewed-on: https://review.whamcloud.com/41427
Reviewed-by: John L. Hammond <jhammond at whamcloud.com>
Reviewed-by: Jian Yu <yujian at whamcloud.com>
Reviewed-by: Oleg Drokin <green at whamcloud.com>
Signed-off-by: James Simmons <jsimmons at infradead.org>
---
 fs/lustre/lov/lov_pack.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/fs/lustre/lov/lov_pack.c b/fs/lustre/lov/lov_pack.c
index ffe9687..1962472 100644
--- a/fs/lustre/lov/lov_pack.c
+++ b/fs/lustre/lov/lov_pack.c
@@ -351,7 +351,6 @@ int lov_getstripe(const struct lu_env *env, struct lov_object *obj,
 	struct lov_user_md_v1 lum;
 	size_t lmmk_size, lum_size = 0;
 	ssize_t lmm_size;
-	static bool printed;
 	int rc = 0;
 
 	if (lsm->lsm_magic != LOV_MAGIC_V1 && lsm->lsm_magic != LOV_MAGIC_V3 &&
@@ -363,13 +362,6 @@ int lov_getstripe(const struct lu_env *env, struct lov_object *obj,
 		goto out;
 	}
 
-	if (!printed) {
-		LCONSOLE_WARN("%s: using old ioctl(LL_IOC_LOV_GETSTRIPE) on " DFID ", use llapi_layout_get_by_path()\n",
-			      current->comm,
-			      PFID(&obj->lo_cl.co_lu.lo_header->loh_fid));
-		printed = true;
-	}
-
 	lmmk_size = lov_comp_md_size(lsm);
 	lmmk = kvzalloc(lmmk_size, GFP_KERNEL);
 	if (!lmmk) {
-- 
1.8.3.1



More information about the lustre-devel mailing list