[lustre-devel] [PATCH 34/39] lnet: socklnd: announce deprecation of 'use_tcp_bonding'
James Simmons
jsimmons at infradead.org
Thu Jan 21 09:16:57 PST 2021
From: Serguei Smirnov <ssmirnov at whamcloud.com>
Add warning to be printed if 'use_tcp_bonding' option is used
notifying the user that the feature is being deprecated.
It is suggested to use MR configuration with dynamic discovery
instead.
Multi-Rail feature doesn't need to be explicitly enabled.
To use MR instead of tcp bonding, group the interfaces
on the same network using the lnetctl utility:
lnetctl net add --net tcp --if eth2,eth3
or via the modprobe configuration file (/etc/modprobe.d/lnet.conf
or /etc/modprobe.d/lustre.conf):
options lnet networks="tcp(eth2,eth3)"
and make sure dynamic discovery is enabled:
lnetctl set discovery 1
MR will aggregate the throughput of all configured and available
networks/interfaces shared between peer nodes.
WC-bug-id: https://jira.whamcloud.com/browse/LU-13641
Lustre-commit: 1a2bf911b97936 ("LU-13641 socklnd: announce deprecation of 'use_tcp_bonding'")
Signed-off-by: Serguei Smirnov <ssmirnov at whamcloud.com>
Reviewed-on: https://review.whamcloud.com/41088
Reviewed-by: Andreas Dilger <adilger at whamcloud.com>
Reviewed-by: Cyril Bordage <cbordage at whamcloud.com>
Signed-off-by: James Simmons <jsimmons at infradead.org>
---
net/lnet/lnet/api-ni.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/net/lnet/lnet/api-ni.c b/net/lnet/lnet/api-ni.c
index 322b25d..c3bf444 100644
--- a/net/lnet/lnet/api-ni.c
+++ b/net/lnet/lnet/api-ni.c
@@ -70,7 +70,7 @@ struct lnet the_lnet = {
static int use_tcp_bonding = false;
module_param(use_tcp_bonding, int, 0444);
MODULE_PARM_DESC(use_tcp_bonding,
- "Set to 1 to use socklnd bonding. 0 to use Multi-Rail");
+ "use_tcp_bonding parameter has been deprecated");
unsigned int lnet_numa_range;
EXPORT_SYMBOL(lnet_numa_range);
@@ -2610,8 +2610,10 @@ void lnet_lib_exit(void)
goto err_empty_list;
}
- /*
- * If LNet is being initialized via DLC it is possible
+ if (use_tcp_bonding)
+ CWARN("'use_tcp_bonding' option has been deprecated. See LU-13641\n");
+
+ /* If LNet is being initialized via DLC it is possible
* that the user requests not to load module parameters (ones which
* are supported by DLC) on initialization. Therefore, make sure not
* to load networks, routes and forwarding from module parameters
--
1.8.3.1
More information about the lustre-devel
mailing list