[lustre-devel] [PATCH 08/13] lustre: ptlrpc: remove might_sleep() in sptlrpc_gc_del_sec()

James Simmons jsimmons at infradead.org
Sat May 15 06:06:05 PDT 2021

From: Nikitas Angelinas <nikitas.angelinas at hpe.com>

sptlrpc_gc_del_sec() calls mutex_lock() which calls might_sleep(), so
the explicit might_sleep() call can be removed as redundant.

WC-bug-id: https://jira.whamcloud.com/browse/LU-14628
Lustre-commit: c31fb42f9aa561ae ("LU-14628 ptlrpc: remove might_sleep() in sptlrpc_gc_del_sec()")
Signed-off-by: Nikitas Angelinas <nikitas.angelinas at hpe.com>
Reviewed-on: https://review.whamcloud.com/43397
Reviewed-by: Andreas Dilger <adilger at whamcloud.com>
Reviewed-by: Shaun Tancheff <shaun.tancheff at hpe.com>
Reviewed-by: James Simmons <jsimmons at infradead.org>
Reviewed-by: Sebastien Buisson <sbuisson at ddn.com>
Signed-off-by: James Simmons <jsimmons at infradead.org>
 fs/lustre/ptlrpc/sec_gc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/lustre/ptlrpc/sec_gc.c b/fs/lustre/ptlrpc/sec_gc.c
index bc76323..fedcf2c 100644
--- a/fs/lustre/ptlrpc/sec_gc.c
+++ b/fs/lustre/ptlrpc/sec_gc.c
@@ -76,8 +76,6 @@ void sptlrpc_gc_del_sec(struct ptlrpc_sec *sec)
 	if (list_empty(&sec->ps_gc_list))
-	might_sleep();
 	/* signal before list_del to make iteration in gc thread safe */

More information about the lustre-devel mailing list