[lustre-devel] [PATCH 15/15] lustre: use 'fallthrough' pseudo keyword for switch
James Simmons
jsimmons at infradead.org
Thu Oct 27 07:05:42 PDT 2022
From: Jian Yu <yujian at whamcloud.com>
'/* fallthrough */' hits implicit-fallthrough error with GCC 11.
This patch replaces the existing '/* fallthrough */' comments and
its variants with the 'fallthrough' pseudo keyword, which was added
by Linux kernel commit v5.4-rc2-141-g294f69e662d1.
WC-bug-id: https://jira.whamcloud.com/browse/LU-15220
Lustre-commit: 5549b1b9e032c6eae ("LU-15220 lustre: use 'fallthrough' pseudo keyword for switch")
Signed-off-by: Jian Yu <yujian at whamcloud.com>
Reviewed-on: https://review.whamcloud.com/46269
Reviewed-by: Andreas Dilger <adilger at whamcloud.com>
Reviewed-by: James Simmons <jsimmons at infradead.org>
Reviewed-by: Peter Jones <pjones at whamcloud.com>
Signed-off-by: James Simmons <jsimmons at infradead.org>
---
fs/lustre/ldlm/ldlm_request.c | 2 +-
fs/lustre/llite/dir.c | 4 ++--
fs/lustre/llite/file.c | 8 ++++----
fs/lustre/llite/llite_lib.c | 4 ++--
fs/lustre/llite/namei.c | 6 +++---
fs/lustre/lov/lov_object.c | 2 +-
fs/lustre/obdecho/echo_client.c | 2 +-
fs/lustre/osc/osc_cache.c | 2 +-
fs/lustre/ptlrpc/pack_generic.c | 8 ++++----
fs/lustre/ptlrpc/ptlrpc_module.c | 12 ++++++------
10 files changed, 25 insertions(+), 25 deletions(-)
diff --git a/fs/lustre/ldlm/ldlm_request.c b/fs/lustre/ldlm/ldlm_request.c
index cf5a290..8b244d7 100644
--- a/fs/lustre/ldlm/ldlm_request.c
+++ b/fs/lustre/ldlm/ldlm_request.c
@@ -1372,7 +1372,7 @@ int ldlm_cli_cancel_list_local(struct list_head *cancels, int count,
case LDLM_IBITS:
if (ns->ns_cancel && ns->ns_cancel(lock) != 0)
break;
- /* fall through */
+ fallthrough;
default:
result = LDLM_POLICY_SKIP_LOCK;
break;
diff --git a/fs/lustre/llite/dir.c b/fs/lustre/llite/dir.c
index 451bd0e..abbba96 100644
--- a/fs/lustre/llite/dir.c
+++ b/fs/lustre/llite/dir.c
@@ -2017,9 +2017,9 @@ static long ll_dir_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
return rc;
}
case OBD_IOC_GETNAME_OLD:
- /* fall through */
+ fallthrough;
case OBD_IOC_GETDTNAME:
- /* fall through */
+ fallthrough;
case OBD_IOC_GETMDNAME:
return ll_get_obd_name(inode, cmd, arg);
case LL_IOC_FLUSHCTX:
diff --git a/fs/lustre/llite/file.c b/fs/lustre/llite/file.c
index f35cddc..350d5df 100644
--- a/fs/lustre/llite/file.c
+++ b/fs/lustre/llite/file.c
@@ -176,7 +176,7 @@ static int ll_close_inode_openhandle(struct inode *inode,
op_data->op_attr_blocks += ((struct inode *)data)->i_blocks;
op_data->op_attr.ia_valid |= ATTR_SIZE;
op_data->op_xvalid |= OP_XVALID_BLOCKS;
- /* fallthrough */
+ fallthrough;
case MDS_CLOSE_LAYOUT_SPLIT:
case MDS_CLOSE_LAYOUT_SWAP: {
struct split_param *sp = data;
@@ -3317,7 +3317,7 @@ static int ll_ladvise_sanity(struct inode *inode,
ladvise_names[advice], rc);
goto out;
}
- /* fallthrough */
+ fallthrough;
case LU_LADVISE_WILLREAD:
case LU_LADVISE_DONTNEED:
default:
@@ -4028,9 +4028,9 @@ static int ll_heat_set(struct inode *inode, enum lu_heat_flag flags)
return 0;
}
case OBD_IOC_GETNAME_OLD:
- /* fall through */
+ fallthrough;
case OBD_IOC_GETDTNAME:
- /* fall through */
+ fallthrough;
case OBD_IOC_GETMDNAME:
return ll_get_obd_name(inode, cmd, arg);
case LL_IOC_HSM_STATE_GET: {
diff --git a/fs/lustre/llite/llite_lib.c b/fs/lustre/llite/llite_lib.c
index 130a723..3dc0030 100644
--- a/fs/lustre/llite/llite_lib.c
+++ b/fs/lustre/llite/llite_lib.c
@@ -1057,7 +1057,7 @@ static int ll_options(char *options, struct super_block *sb)
case LL_SBI_CHECKSUM:
sbi->ll_checksum_set = 1;
- /* fall through */
+ fallthrough;
case LL_SBI_USER_XATTR:
case LL_SBI_USER_FID2PATH:
case LL_SBI_LRU_RESIZE:
@@ -1135,7 +1135,7 @@ static int ll_options(char *options, struct super_block *sb)
LCONSOLE_ERROR_MSG(0x152,
"invalid %s option\n", s1);
}
- /* fall through */
+ fallthrough;
default:
break;
}
diff --git a/fs/lustre/llite/namei.c b/fs/lustre/llite/namei.c
index 8b21effc..5ac634c 100644
--- a/fs/lustre/llite/namei.c
+++ b/fs/lustre/llite/namei.c
@@ -410,13 +410,13 @@ int ll_md_need_convert(struct ldlm_lock *lock)
switch (lock->l_req_mode) {
case LCK_PR:
mode = LCK_PR;
- /* fall-through */
+ fallthrough;
case LCK_PW:
mode |= LCK_CR;
break;
case LCK_CW:
mode = LCK_CW;
- /* fall-through */
+ fallthrough;
case LCK_CR:
mode |= LCK_CR;
break;
@@ -1784,7 +1784,7 @@ static int ll_mknod(struct inode *dir, struct dentry *dchild,
case 0:
mode |= S_IFREG;
/* for mode = 0 case */
- /* fall through */
+ fallthrough;
case S_IFREG:
case S_IFCHR:
case S_IFBLK:
diff --git a/fs/lustre/lov/lov_object.c b/fs/lustre/lov/lov_object.c
index 5245fd6..34cb6a0 100644
--- a/fs/lustre/lov/lov_object.c
+++ b/fs/lustre/lov/lov_object.c
@@ -2308,7 +2308,7 @@ int lov_read_and_clear_async_rc(struct cl_object *clob)
}
case LLT_RELEASED:
case LLT_EMPTY:
- /* fall through */
+ fallthrough;
case LLT_FOREIGN:
break;
default:
diff --git a/fs/lustre/obdecho/echo_client.c b/fs/lustre/obdecho/echo_client.c
index f25ea41..d7de6e4 100644
--- a/fs/lustre/obdecho/echo_client.c
+++ b/fs/lustre/obdecho/echo_client.c
@@ -1072,7 +1072,7 @@ static int echo_client_brw_ioctl(const struct lu_env *env, int rw,
}
rw = OBD_BRW_WRITE;
- /* fall through */
+ fallthrough;
case OBD_IOC_BRW_READ:
rc = echo_client_brw_ioctl(env, rw, exp, data);
goto out;
diff --git a/fs/lustre/osc/osc_cache.c b/fs/lustre/osc/osc_cache.c
index 12d9ab5..e563809 100644
--- a/fs/lustre/osc/osc_cache.c
+++ b/fs/lustre/osc/osc_cache.c
@@ -230,7 +230,7 @@ static int __osc_extent_sanity_check(struct osc_extent *ext,
rc = 65;
goto out;
}
- /* fall through */
+ fallthrough;
default:
if (atomic_read(&ext->oe_users) > 0) {
rc = 70;
diff --git a/fs/lustre/ptlrpc/pack_generic.c b/fs/lustre/ptlrpc/pack_generic.c
index 9acea24..9a0341c 100644
--- a/fs/lustre/ptlrpc/pack_generic.c
+++ b/fs/lustre/ptlrpc/pack_generic.c
@@ -783,7 +783,7 @@ u32 lustre_msg_get_flags(struct lustre_msg *msg)
CERROR("invalid msg %p: no ptlrpc body!\n", msg);
}
- /* fall through */
+ fallthrough;
default:
/* flags might be printed in debug code while message
* uninitialized
@@ -851,7 +851,7 @@ u32 lustre_msg_get_op_flags(struct lustre_msg *msg)
CERROR("invalid msg %p: no ptlrpc body!\n", msg);
}
- /* fall through */
+ fallthrough;
default:
return 0;
}
@@ -1032,7 +1032,7 @@ int lustre_msg_get_status(struct lustre_msg *msg)
CERROR("invalid msg %p: no ptlrpc body!\n", msg);
}
- /* fall through */
+ fallthrough;
default:
/* status might be printed in debug code while message
* uninitialized
@@ -2069,7 +2069,7 @@ void lustre_swab_lmv_user_md(struct lmv_user_md *lum)
switch (lum->lum_magic) {
case LMV_USER_MAGIC_SPECIFIC:
count = lum->lum_stripe_count;
- /* fallthrough */
+ fallthrough;
case __swab32(LMV_USER_MAGIC_SPECIFIC):
lustre_swab_lmv_user_md_objects(lum->lum_objects, count);
break;
diff --git a/fs/lustre/ptlrpc/ptlrpc_module.c b/fs/lustre/ptlrpc/ptlrpc_module.c
index 7e29a91..95a29b2 100644
--- a/fs/lustre/ptlrpc/ptlrpc_module.c
+++ b/fs/lustre/ptlrpc/ptlrpc_module.c
@@ -135,23 +135,23 @@ static int __init ptlrpc_init(void)
switch (cleanup_phase) {
case 8:
ptlrpc_nrs_fini();
- /* Fall through */
+ fallthrough;
case 7:
sptlrpc_fini();
- /* Fall through */
+ fallthrough;
case 6:
ldlm_exit();
- /* Fall through */
+ fallthrough;
case 5:
ptlrpc_connection_fini();
- /* Fall through */
+ fallthrough;
case 3:
ptlrpc_request_cache_fini();
- /* Fall through */
+ fallthrough;
case 1:
ptlrpc_hr_fini();
req_layout_fini();
- /* Fall through */
+ fallthrough;
default:
break;
}
--
1.8.3.1
More information about the lustre-devel
mailing list