[lustre-devel] [PATCH 29/42] lustre: llite: remove false outdated comment

James Simmons jsimmons at infradead.org
Mon Jan 23 15:00:42 PST 2023


From: Aurelien Degremont <degremoa at amazon.com>

Old commit from before Lustre was submitted upstream changed
ll_i2gids() behavior without updating the function
documentation accordingly. Fix it as this is confusing.

WC-bug-id: https://jira.whamcloud.com/browse/LU-16438
Lustre-commit: 557bb0004d7ea1d87 ("LU-16438 llite: remove false outdated comment");
Signed-off-by: Aurelien Degremont <degremoa at amazon.com>
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/49539
Reviewed-by: Andreas Dilger <adilger at whamcloud.com>
Reviewed-by: Sebastien Buisson <sbuisson at ddn.com>
Reviewed-by: Oleg Drokin <green at whamcloud.com>
Signed-off-by: James Simmons <jsimmons at infradead.org>
---
 fs/lustre/llite/namei.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/fs/lustre/llite/namei.c b/fs/lustre/llite/namei.c
index 93abec81896f..f23d3ae49fae 100644
--- a/fs/lustre/llite/namei.c
+++ b/fs/lustre/llite/namei.c
@@ -518,11 +518,7 @@ u32 ll_i2suppgid(struct inode *i)
 		return (u32)(-1);
 }
 
-/* Pack the required supplementary groups into the supplied groups array.
- * If we don't need to use the groups from the target inode(s) then we
- * instead pack one or more groups from the user's supplementary group
- * array in case it might be useful.  Not needed if doing an MDS-side upcall.
- */
+/* Pack the required supplementary groups into the supplied groups array. */
 void ll_i2gids(u32 *suppgids, struct inode *i1, struct inode *i2)
 {
 	LASSERT(i1);
-- 
2.27.0



More information about the lustre-devel mailing list