[lustre-devel] [PATCH 23/25] lustre: remove obsolete OBD_FAIL_OSC_DIO_PAUSE fail_loc

James Simmons jsimmons at infradead.org
Thu Jan 30 06:11:13 PST 2025


From: Patrick Farrell <pfarrell at whamcloud.com>

The fail_loc used for testing was removed in Lustre 2.0.
The fail_loc tests for a bug which should be obvious - a
serious delay when doing DIO writes - and is definitely
fixed in current versions.  (Bugzilla 15950)

And without the fail_loc, the test isn't doing anything
interesting.  But the timer based aspect of it fails
occasionally due to hardware delays.  So let's just remove
the fail_loc.

WC-bug-id: https://jira.whamcloud.com/browse/LU-13706
lustre-commit: 59d5bb1558b281d75 ("LU-13706 tests: remove test 119d")
Signed-off-by: Patrick Farrell <pfarrell at whamcloud.com>
Reviewed-on: https://review.whamcloud.com/c/fs/lustre-release/+/50731
Reviewed-by: Andreas Dilger <adilger at whamcloud.com>
Reviewed-by: Alex Zhuravlev <bzzz at whamcloud.com>
Reviewed-by: Oleg Drokin <green at whamcloud.com>
Signed-off-by: James Simmons <jsimmons at infradead.org>
---
 fs/lustre/include/obd_support.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/lustre/include/obd_support.h b/fs/lustre/include/obd_support.h
index 43b4684f418a..cee7e3164d66 100644
--- a/fs/lustre/include/obd_support.h
+++ b/fs/lustre/include/obd_support.h
@@ -327,7 +327,6 @@ extern char obd_jobid_var[];
 #define OBD_FAIL_OSC_BRW_PREP_REQ2			0x40a
 /* #define OBD_FAIL_OSC_CONNECT_CKSUM	 0x40b Obsolete since 2.9 */
 #define OBD_FAIL_OSC_CKSUM_ADLER_ONLY			0x40c
-#define OBD_FAIL_OSC_DIO_PAUSE				0x40d
 #define OBD_FAIL_OSC_OBJECT_CONTENTION			0x40e
 #define OBD_FAIL_OSC_CP_CANCEL_RACE			0x40f
 #define OBD_FAIL_OSC_CP_ENQ_RACE			0x410
-- 
2.39.3



More information about the lustre-devel mailing list