<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Question for lustre-devel... Isn't this the opposite of the style
that we're currently trying to use in Gerrit submissions? Is my
memory faulty?<br>
<div class="moz-forward-container"><br>
<br>
-------- Original Message --------
<table class="moz-email-headers-table" border="0" cellpadding="0"
cellspacing="0">
<tbody>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Subject:
</th>
<td>[HPDD-discuss] [PATCH 01/12] staging: lustre: fid: Use
!x to check for kzalloc failure</td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">Date: </th>
<td>Sat, 20 Jun 2015 18:58:59 +0200</td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">From: </th>
<td>Julia Lawall <a class="moz-txt-link-rfc2396E" href="mailto:Julia.Lawall@lip6.fr"><Julia.Lawall@lip6.fr></a></td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">To: </th>
<td>Oleg Drokin <a class="moz-txt-link-rfc2396E" href="mailto:oleg.drokin@intel.com"><oleg.drokin@intel.com></a></td>
</tr>
<tr>
<th align="RIGHT" nowrap="nowrap" valign="BASELINE">CC: </th>
<td><a class="moz-txt-link-rfc2396E" href="mailto:devel@driverdev.osuosl.org"><devel@driverdev.osuosl.org></a>, Greg Kroah-Hartman
<a class="moz-txt-link-rfc2396E" href="mailto:gregkh@linuxfoundation.org"><gregkh@linuxfoundation.org></a>,
<a class="moz-txt-link-rfc2396E" href="mailto:kernel-janitors@vger.kernel.org"><kernel-janitors@vger.kernel.org></a>,
<a class="moz-txt-link-rfc2396E" href="mailto:linux-kernel@vger.kernel.org"><linux-kernel@vger.kernel.org></a>,
<a class="moz-txt-link-rfc2396E" href="mailto:HPDD-discuss@lists.01.org"><HPDD-discuss@lists.01.org></a></td>
</tr>
</tbody>
</table>
<br>
<br>
<pre>!x is more normal for kzalloc failure in the kernel.
The semantic patch that makes this change is as follows:
(<a class="moz-txt-link-freetext" href="http://coccinelle.lip6.fr/">http://coccinelle.lip6.fr/</a>)
// <smpl>
@@
expression x;
statement S1, S2;
@@
x = kzalloc(...);
if (
- x == NULL
+ !x
) S1 else S2
// </smpl>
Signed-off-by: Julia Lawall <a class="moz-txt-link-rfc2396E" href="mailto:Julia.Lawall@lip6.fr"><Julia.Lawall@lip6.fr></a>
---
drivers/staging/lustre/lustre/fid/fid_request.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -u -p a/drivers/staging/lustre/lustre/fid/fid_request.c b/drivers/staging/lustre/lustre/fid/fid_request.c
--- a/drivers/staging/lustre/lustre/fid/fid_request.c
+++ b/drivers/staging/lustre/lustre/fid/fid_request.c
@@ -498,11 +498,11 @@ int client_fid_init(struct obd_device *o
int rc;
cli->cl_seq = kzalloc(sizeof(*cli->cl_seq), GFP_NOFS);
- if (cli->cl_seq == NULL)
+ if (!cli->cl_seq)
return -ENOMEM;
prefix = kzalloc(MAX_OBD_NAME + 5, GFP_NOFS);
- if (prefix == NULL) {
+ if (!prefix) {
rc = -ENOMEM;
goto out_free_seq;
}
_______________________________________________
HPDD-discuss mailing list
<a class="moz-txt-link-abbreviated" href="mailto:HPDD-discuss@lists.01.org">HPDD-discuss@lists.01.org</a>
<a class="moz-txt-link-freetext" href="https://lists.01.org/mailman/listinfo/hpdd-discuss">https://lists.01.org/mailman/listinfo/hpdd-discuss</a>
</pre>
<br>
</div>
<br>
</body>
</html>