<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
<br class="">
<div>
<blockquote type="cite" class="">
<div class="">Le Jun 10, 2016 à 18:36, Greg Kroah-Hartman <<a href="mailto:gregkh@linuxfoundation.org" class="">gregkh@linuxfoundation.org</a>> a écrit :</div>
<br class="Apple-interchange-newline">
<div class=""><br class="">
A: No.<br class="">
Q: Should I include quotations after my reply?<br class="">
<br class="">
<a href="http://daringfireball.net/2007/07/on_top" class="">http://daringfireball.net/2007/07/on_top</a><br class="">
</div>
</blockquote>
<div><br class="">
</div>
Thanks for the email formatting lesson! ;-) New comments/answers inlined …</div>
<div><br class="">
<blockquote type="cite" class="">On Fri, Jun 10, 2016 at 03:25:28PM +0000, Faccini, Bruno wrote:<br class="">
<blockquote type="cite" class="">Hello,<br class="">
The intent of this patch is not to solve the corruptions for sure, but<br class="">
only to avoid the concerned MEs/small-MDs LNet structs to be quite<br class="">
frequently impacted due to their high allocation/free rate.<br class="">
</blockquote>
<br class="">
But that’s not what the patch description said :(<br class="">
</blockquote>
True. This is mainly because the original patch text has not been changed, but if this patch (originally to debug <size-128> kmem_cache corruptions) has been kept to be integrated this comes from our reflexion that this could also be an enhancement.<br class="">
<blockquote type="cite" class=""><br class="">
And again, putting them in a separate cache is not going to save much of<br class="">
anything, given that your caches might have been merged together anyway.<br class="">
<br class="">
<blockquote type="cite" class="">This may also possibly help to save cycles due to high usage and<br class="">
contention when using a generic kmem_cache (when they stay separate<br class="">
from others, thanks for the precision!).<br class="">
</blockquote>
<br class="">
Have you measured this?<br class="">
</blockquote>
No, but I will try to measure it.</div>
<div><br class="">
<blockquote type="cite" class=""><br class="">
This isn't applicable for 4.7-rc at this time, _unless_ it fixes a bug,<br class="">
which is why I pushed back on this. If you want your own cache for<br class="">
these variables, fine, I don't care, but that makes it a 4.8-rc1 patch<br class="">
instead.<br class="">
</blockquote>
I have no problem with that.</div>
<div><br class="">
<blockquote type="cite" class=""><br class="">
hope that helps explain things better,<br class="">
</blockquote>
Yes, definitely.</div>
<div><br class="">
<blockquote type="cite" class=""><br class="">
greg k-h<br class="">
</blockquote>
</div>
<br class="">
<div class="">Thanks,</div>
<div class="">Bruno.</div>
<div class=""><br class="">
</div>
<p>---------------------------------------------------------------------<br>
Intel Corporation SAS (French simplified joint stock company)<br>
Registered headquarters: "Les Montalets"- 2, rue de Paris, <br>
92196 Meudon Cedex, France<br>
Registration Number: 302 456 199 R.C.S. NANTERRE<br>
Capital: 4,572,000 Euros</p>
<p>This e-mail and any attachments may contain confidential material for<br>
the sole use of the intended recipient(s). Any review or distribution<br>
by others is strictly prohibited. If you are not the intended<br>
recipient, please contact the sender and delete all copies.</p></body>
</html>