<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from text --><style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<meta content="text/html; charset=UTF-8">
<style type="text/css" style="">
<!--
p
{margin-top:0;
margin-bottom:0}
-->
</style>
<div dir="ltr">
<div id="x_divtagdefaultwrapper" style="font-size:12pt; color:#000000; font-family:Calibri,Arial,Helvetica,sans-serif">
<p>Arnd,</p>
<p><br>
</p>
<p>The description and the actual patch don't seem to match up. Am I missing something?</p>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> lustre-devel <lustre-devel-bounces@lists.lustre.org> on behalf of Arnd Bergmann <arnd@arndb.de><br>
<b>Sent:</b> Monday, October 17, 2016 5:08:55 PM<br>
<b>To:</b> Oleg Drokin<br>
<b>Cc:</b> devel@driverdev.osuosl.org; Arnd Bergmann; Greg Kroah-Hartman; linux-kernel@vger.kernel.org; Linus Torvalds; lustre-devel@lists.lustre.org<br>
<b>Subject:</b> [lustre-devel] [PATCH 08/28] staging: lustre: restore initialization of return code</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">A recent rework removed the initialization of the successful return<br>
code from lpfc_write_firmware:<br>
<br>
drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_write_firmware':<br>
drivers/scsi/lpfc/lpfc_init.c:10333:214: error: format '%ld' expects argument of type 'long int', but argument 9 has type 'size_t {aka const unsigned int}' [-Werror=format=]<br>
<br>
This adds it back.<br>
<br>
Fixes: e10a431b3fd0 ("staging: lustre: lov: move LSM to LOV layer")<br>
Cc: John L. Hammond <john.hammond@intel.com><br>
Cc: Jinshan Xiong <jinshan.xiong@intel.com><br>
Cc: James Simmons <jsimmons@infradead.org><br>
Signed-off-by: Arnd Bergmann <arnd@arndb.de><br>
---<br>
drivers/staging/lustre/lustre/lov/lov_pack.c | 2 ++<br>
1 file changed, 2 insertions(+)<br>
<br>
diff --git a/drivers/staging/lustre/lustre/lov/lov_pack.c b/drivers/staging/lustre/lustre/lov/lov_pack.c<br>
index be6e985..0439f54 100644<br>
--- a/drivers/staging/lustre/lustre/lov/lov_pack.c<br>
+++ b/drivers/staging/lustre/lustre/lov/lov_pack.c<br>
@@ -474,6 +474,8 @@ int lov_getstripe(struct lov_object *obj, struct lov_stripe_md *lsm,<br>
((struct lov_user_md *)lmmk)->lmm_stripe_count = lum.lmm_stripe_count;<br>
if (copy_to_user(lump, lmmk, lmm_size))<br>
rc = -EFAULT;<br>
+ else<br>
+ rc = 0;<br>
<br>
out_free:<br>
kfree(lmmk);<br>
-- <br>
2.9.0<br>
<br>
_______________________________________________<br>
lustre-devel mailing list<br>
lustre-devel@lists.lustre.org<br>
<a href="http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org">http://lists.lustre.org/listinfo.cgi/lustre-devel-lustre.org</a><br>
</div>
</span></font>
</body>
</html>