<div dir="ltr"><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Le ven. 19 juil. 2019 à 17:44, Degremont, Aurelien <<a href="mailto:degremoa@amazon.com">degremoa@amazon.com</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
<br>
Le 19/07/2019 17:21, « James Simmons » <<a href="mailto:jsimmons@infradead.org" target="_blank">jsimmons@infradead.org</a>> a écrit :<br>
<br>
<br>
> Hi!<br>
> <br>
> <br>
> <br>
> I'm trying to run sanity-hsm.sh tests in my lustre source directory as I'm used to.<br>
> <br>
> Since libtool patch was landed, tools like lhsmtool_posix are executed through a wrapper and appear in process list as 'lt-lhsmtool_posix'.<br>
> <br>
> Some tests try to find and kill them, relying on command like:<br>
> <br>
> <br>
> <br>
> "ps -C $HSMTOOL"<br>
> <br>
> <br>
> <br>
> Even if run through "libtool execute ps -C $HSMTOOL" (as it is in the source right now) this command does not catch the proper process and<br>
> so fail the test.<br>
> <br>
> <br>
> <br>
> I'm wondering what the proper way to run the test suite to have it working and how this is working in Maloo?<br>
> <br>
> I'm doing:<br>
> <br>
> <br>
> <br>
> git clone<br>
> <br>
> autogen<br>
> <br>
> configure<br>
> <br>
> make<br>
> <br>
> sudo REFORMAT=: ./lustre/tests/sanity-hsm.sh<br>
> <br>
> <br>
> <br>
> <br>
> <br>
> <br>
> <br>
> By the way, when hsm helper functions were moved from sanity-hsm.sh to test-framework.sh (f172b1168, for PCC), some of them were just<br>
> copied and not moved. So there are several duplicates between these 2 files. I think that's not on purpose?<br>
<br>
What version of lustre are you testing with? Their was a patch landed to <br>
handle this.<br>
<br>
LU-11742 test: have libtool execute the test binaries<br>
<br>
which is lustre commit f9e5224fbb60bb8b44753b7be10cb06108627f89. This has <br>
been back ported to 2.12 LTS. Can you see if your lustre tree has this <br>
fix. <br>
<br>
See <a href="https://www.gnu.org/software/libtool/manual/html_node/Debugging-executables.html" rel="noreferrer" target="_blank">https://www.gnu.org/software/libtool/manual/html_node/Debugging-executables.html</a><br>
for details about using libtool against the binary wrappers. <br>
<br>
I'm running master.<br>
That's exactly the patch which is giving me issue.<br>
I can run sanity-hsm successfully prior to this patch, not after.<br>
<br>
Aurélien<br></blockquote><div><br></div><div>I concur : I cannot run sanity-hsm on master. Works fine when checking out the commit right before the libtool patch , breaks if the patch is applied.</div><div><br></div><div>With some testing it appears this is because "libtool execute" does does not use the PATH environment variable when it resolves paths :<br></div><div><br></div><div>$> pwd</div><div>/home/user/lustre-release</div><div>$> export PATH=lustre/utils:/usr/bin<br></div><div>$> which lhsmtool_posix</div><div>/home/user/lustre-release/lustre/utils/lhsmtool_posix</div><div>$> libtool execute echo lhsmtool_posix</div><div>lhsmtool_posix</div><div>$> libtool execute echo lustre/utils/lhsmtool_posix</div><div>/home/user/lustre-release/luster/utils/.libs/lhsmtool_posix</div><div><br></div><div>I suspect this works on Maloo because Maloo does not run tests from the git repo but rather from installed rpms (=> no libtool wrappers).</div><div><br></div><div>@James, I can see you asked me a follow-up review on the patch that introduces this regressions, and I did not answer, Sorry about that. I will try to keep better track of patches I reviewed at least once... In this spirit, I will try to update my review of <a href="https://review.whamcloud.com/#/c/33572/">this change</a> this weekend. =)<br></div><div><br></div><div>Cheers,<br></div><div>Quentin<br></div></div></div>