<div dir="ltr">Looks like it's better to clean it up :)<br></div><div class="gmail_extra"><br><div class="gmail_quote">On 9 September 2016 at 01:59, James Simmons <span dir="ltr"><<a href="mailto:jsimmons@infradead.org" target="_blank">jsimmons@infradead.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
> We get 1 warning when building kernel with W=1:<br>
> drivers/staging/lustre/lustre/<wbr>lov/lov_object.c:956:23: warning: no previous prototype for 'lov_lsm_get' [-Wmissing-prototypes]<br>
> drivers/staging/lustre/lustre/<wbr>lov/lov_object.c:972:6: warning: no previous prototype for 'lov_lsm_put' [-Wmissing-prototypes]<br>
> drivers/staging/lustre/lustre/<wbr>lov/lov_object.c:979:5: warning: no previous prototype for 'lov_read_and_clear_async_rc' [-Wmissing-prototypes]<br>
><br>
> In fact, these functions are declared in ../llite/vvp_internal.h,<br>
> so this patch add missing header dependencies.<br>
><br>
> Signed-off-by: Baoyou Xie <<a href="mailto:baoyou.xie@linaro.org">baoyou.xie@linaro.org</a>><br>
<br>
</span>Nak. The header vvp_internal.h is meant to private to the llite layer.<br>
Looking at the coming patch updates I see lov_lsm_[put|get] will not be<br>
used in the lov later. Now lov_read_and_clear_async is still used in<br>
both layers. The header used for this case is cl_object.h. Might rename<br>
that function to be consistent with the rest of the header. I will look<br>
into a cleanup for this.<br>
<span class=""><br>
> ---<br>
> drivers/staging/lustre/lustre/<wbr>lov/lov_object.c | 1 +<br>
> 1 file changed, 1 insertion(+)<br>
><br>
> diff --git a/drivers/staging/lustre/<wbr>lustre/lov/lov_object.c b/drivers/staging/lustre/<wbr>lustre/lov/lov_object.c<br>
> index f9621b0..912c416 100644<br>
> --- a/drivers/staging/lustre/<wbr>lustre/lov/lov_object.c<br>
> +++ b/drivers/staging/lustre/<wbr>lustre/lov/lov_object.c<br>
> @@ -38,6 +38,7 @@<br>
> #define DEBUG_SUBSYSTEM S_LOV<br>
><br>
> #include "lov_cl_internal.h"<br>
> +#include "../llite/vvp_internal.h"<br>
><br>
> /** \addtogroup lov<br>
> * @{<br>
> --<br>
> 2.7.4<br>
><br>
</span>> ______________________________<wbr>_________________<br>
> devel mailing list<br>
> <a href="mailto:devel@linuxdriverproject.org">devel@linuxdriverproject.org</a><br>
> <a href="http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel" rel="noreferrer" target="_blank">http://driverdev.<wbr>linuxdriverproject.org/<wbr>mailman/listinfo/driverdev-<wbr>devel</a><br>
><br>
</blockquote></div><br></div>