<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
</head>
<body>
<br>
Just throwing this in, I agree with Neil very strongly here. Ive seen some patches recently with ~20 lines of change and 200 lines of whitespace.<br>
<br>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> lustre-devel <lustre-devel-bounces@lists.lustre.org> on behalf of NeilBrown <neilb@suse.com><br>
<b>Sent:</b> Monday, December 17, 2018 6:09:57 PM<br>
<b>To:</b> James Simmons; Andreas Dilger; Oleg Drokin; Bobi Jam; Jinshan Xiong<br>
<b>Cc:</b> Lustre Development List<br>
<b>Subject:</b> Re: [lustre-devel] [PATCH 03/28] lustre: lov: merge lov_mds_md_v3 and lov_mds_md_v1 handling</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">On Mon, Dec 17 2018, James Simmons wrote:<br>
<br>
> From: Bobi Jam <bobijam@hotmail.com><br>
><br>
> Several of the struct lsm_operations functions for both v1 and v3<br>
> are nearly identical. Let merge them together.<br>
Let's<br>
<br>
> <br>
> -const struct lsm_operations lsm_v1_ops = {<br>
> - .lsm_free = lsm_free_plain,<br>
> - .lsm_stripe_by_index = lsm_stripe_by_index_plain,<br>
> - .lsm_stripe_by_offset = lsm_stripe_by_offset_plain,<br>
> - .lsm_lmm_verify = lsm_lmm_verify_v1,<br>
> - .lsm_unpackmd = lsm_unpackmd_v1,<br>
> +const static struct lsm_operations lsm_v1_ops = {<br>
> + .lsm_stripe_by_index = lsm_stripe_by_index_plain,<br>
> + .lsm_stripe_by_offset = lsm_stripe_by_offset_plain,<br>
> + .lsm_lmm_verify = lsm_lmm_verify_v1,<br>
> + .lsm_unpackmd = lsm_unpackmd_v1,<br>
<br>
I *SO* wish you would stop combining white-spaces fixes with other<br>
changes in the same patch!!!<br>
The above hunk should just add the 'static' and remove the 'lsm_free'.<br>
The rest is just noise and makes it harder to review the patch.<br>
<br>
<br>
Thanks,<br>
NeilBrown<br>
</div>
</span></font></div>
</body>
</html>