[Lustre-discuss] Lustre File Locking not locking

[Andreas Dilger]

On Aug 21, 2008  12:23 +0200, Bernd Schubert wrote:
> IHMO, instead of calling LBUG() here, simply "return EINVAL" should be done.
> So with the present code it seems whenever the userspace is setting a 
> wrong struct flock l_type, it will trigger a LBUG(). I'm going to check this
> and then will fill in a bugzilla entry.

Yes, this is very old code, and it should be fixed.  Ideally it would
be fixed to handle this lock type properly, but EINVAL is definitely
better than the LBUG.  I believe there is already a bug open for this.

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.