[Lustre-discuss] problem with too many (default) ACLs on a directory

[Frederik Ferner]

Andreas Dilger wrote:
> On 2010-05-13, at 04:38, Frederik Ferner wrote:
>> Andreas Dilger wrote:

>>> The relevant code is:
>>> int mds_setxattr_internal(struct ptlrpc_request *req, struct mds_body *body)
>>> {
>>>        /* currently lustre limit xattr size */
>>>        if (body->valid & OBD_MD_FLXATTR &&
>>>            !strcmp(xattr_name, XATTR_NAME_ACL_ACCESS)) {
>>>                xattrlen = lustre_msg_buflen(req->rq_reqmsg,
>>>                                             REQ_REC_OFF + 2);
>>>                if (xattrlen > LUSTRE_POSIX_ACL_MAX_SIZE)
>>>                        GOTO(out, -ERANGE);
>>>        }
>>> but it should also check if the xattr_name is XATTR_NAME_ACL_DEFAULT.
>>>        if (body->valid & OBD_MD_FLXATTR &&
>>>            (!strcmp(xattr_name, XATTR_NAME_ACL_ACCESS) ||
>>>             !strcmp(xattr_name, XATTR_NAME_ACL_DEFAULT)) {
>> Should we open a bug to track this?
> 
> Please do.  If it includes this comment as a patch, it will likely make it into 1.8.4.

Done:
https://bugzilla.lustre.org/show_bug.cgi?id=22820

Thanks,
Frederik
-- 
Frederik Ferner
Computer Systems Administrator		phone: +44 1235 77 8624
Diamond Light Source Ltd.		mob:   +44 7917 08 5110
(Apologies in advance for the lines below. Some bits are a legal
requirement and I have no control over them.)