<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On Apr 27, 2012, at 7:48 AM, Andreas Dilger wrote:</div><blockquote type="cite"><div><font class="Apple-style-span" color="#000000"><br></font>- there was no objection to converting the Lustre code from spaces<br> to tabs. My proposal was that build/checkpatch.pl could require<br> tabs immediately, and new patches should be submitted with tabs<br> on all new/modified lines (and optionally all lines on small<br> functions to avoid messy formatting). This will avoid issues<br> with current patches in flight, and also avoid "git annotate"<br> showing the jumbo replace-all-spaces-with-tabs patch for every<br> line in Lustre, and I think a good fraction of lines will be<br> updated in the next 9-12 months or more. As we approach the<br> actual time for upstream kernel submission is close, then we can<br> make a final effort to clean up remaining lines in idle code<br> (which will also be unlikely to conflict with existing work).<br></div></blockquote><div><br></div><div>Lustre also requires to align the first alphabet of members while defining a structure, but linux kernel only aligns any first character (for example, * for pointer), then which way we should choose?</div><div>we probably should update our coding guidelines ASAP.</div><div><br></div><div>Liang</div><div><br></div></div></body></html>