<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"Times New Roman \(Body CS\)";
panose-1:2 2 6 3 5 4 5 2 3 4;}
@font-face
{font-family:-webkit-standard;
panose-1:2 11 6 4 2 2 2 2 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;
font-weight:normal;
font-style:normal;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-CA" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="font-size:14.0pt">Furthermore, I notice that you mention that you are running “</span><span style="font-family:"-webkit-standard",serif;color:black">DDN Lustre servers 2.12.6”. so you should also check with DDN
support before making any changes to the code that you are running in production.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:14.0pt"><o:p> </o:p></span></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span style="font-size:12.0pt;color:black">From: </span></b><span style="font-size:12.0pt;color:black">lustre-discuss <lustre-discuss-bounces@lists.lustre.org> on behalf of Andreas Dilger via lustre-discuss <lustre-discuss@lists.lustre.org><br>
<b>Reply-To: </b>Andreas Dilger <adilger@whamcloud.com><br>
<b>Date: </b>Wednesday, May 5, 2021 at 12:57 AM<br>
<b>To: </b>Andrej Filipcic <andrej.filipcic@ijs.si><br>
<b>Cc: </b>"lustre-discuss@lists.lustre.org" <lustre-discuss@lists.lustre.org><br>
<b>Subject: </b>Re: [lustre-discuss] kernel 5.10 on RHEL8 and lustre-client kind of working<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p class="MsoNormal">Hi Andrej, <o:p></o:p></p>
<div>
<p class="MsoNormal">could you please check if your change is included in one of the patches in <a href="https://jira.whamcloud.com/browse/LU-14195">https://jira.whamcloud.com/browse/LU-14195</a> "Support for linux kernel version 5.10"? If not, that would
be the natural ticket to reference when submit this patch. Note, however, that the same code also needs to be conditional based on configure checks of the kernel for the appropriate symbols so that it works on all supported kernels.<o:p></o:p></p>
<div>
<p class="MsoNormal"><br>
<br>
<o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">On May 3, 2021, at 09:47, Andrej Filipcic via lustre-discuss <<a href="mailto:lustre-discuss@lists.lustre.org">lustre-discuss@lists.lustre.org</a>> wrote:<o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal"><br>
Hi,<br>
<br>
I compiled the master from today (commit 0b7ddf32e336b06d459880faf9831db43ffae9cf) on 5.10.34 kernel with mpi support (RHEL8.3 otherwise), and it seems to work properly for me. I needed to do the following changes, while cross-checking LU-14195<br>
<br>
diff --git a/lnet/lnet/lib-socket.c b/lnet/lnet/lib-socket.c<br>
index 4a86114ecf..1412d9deb0 100644<br>
--- a/lnet/lnet/lib-socket.c<br>
+++ b/lnet/lnet/lib-socket.c<br>
@@ -343,9 +343,10 @@ struct socket *<br>
lnet_sock_listen(int local_port, int backlog, struct net *ns)<br>
{<br>
struct socket *sock;<br>
- mm_segment_t oldfs;<br>
+ //mm_segment_t oldfs;<br>
int val = 0;<br>
int rc;<br>
+ sockptr_t sval;<br>
<br>
sock = lnet_sock_create(-1, NULL, local_port, ns);<br>
if (IS_ERR(sock)) {<br>
@@ -360,11 +361,13 @@ lnet_sock_listen(int local_port, int backlog, struct net *ns)<br>
* This is the default, but it can be overridden so<br>
* we force it back.<br>
*/<br>
- oldfs = get_fs();<br>
- set_fs(KERNEL_DS);<br>
+ //oldfs = get_fs();<br>
+ //set_fs(KERNEL_DS);<br>
+ //sock->ops->setsockopt(sock, IPPROTO_IPV6, IPV6_V6ONLY,<br>
+ // (char __user __force *) &val, sizeof(val));<br>
sock->ops->setsockopt(sock, IPPROTO_IPV6, IPV6_V6ONLY,<br>
- (char __user __force *) &val, sizeof(val));<br>
- set_fs(oldfs);<br>
+ sval, sizeof(val));<br>
+ //set_fs(oldfs);<br>
<br>
rc = kernel_listen(sock, backlog);<br>
if (rc == 0)<br>
<br>
With this version, the client works quite fine over o2ib (Mellanox drivers) with DDN Lustre servers 2.12.6, tested with several writes, unpacking and compiling kernel in lustre etc...<br>
<br>
Can somebody please tell if the fixes above are correct, or if there is any danger in using the master for clients in production?<br>
<br>
Best regards,<br>
Andrej<br>
<br>
-- <br>
_____________________________________________________________<br>
prof. dr. Andrej Filipcic, <a href="mailto:Andrej.Filipcic@ijs.si">E-mail: Andrej.Filipcic@ijs.si</a><br>
Department of Experimental High Energy Physics - F9<br>
Jozef Stefan Institute, Jamova 39, P.o.Box 3000<br>
SI-1001 Ljubljana, Slovenia<br>
Tel.: +386-1-477-3674 Fax: +386-1-425-7074<br>
-------------------------------------------------------------<br>
<br>
_______________________________________________<br>
lustre-discuss mailing list<br>
<a href="mailto:lustre-discuss@lists.lustre.org">lustre-discuss@lists.lustre.org</a><br>
http://lists.lustre.org/listinfo.cgi/lustre-discuss-lustre.org<o:p></o:p></p>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<p class="MsoNormal"><span style="color:black">Cheers, Andreas<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="color:black">--<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="color:black">Andreas Dilger<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="color:black">Principal Lustre Architect<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="color:black">Whamcloud<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="color:black"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="color:black"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span style="color:black"><o:p> </o:p></span></p>
</div>
</div>
</div>
</div>
</div>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><o:p> </o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</body>
</html>